To prioritize port QoS policies over network QoS policies

Bug #1665282 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rodolfo Alonso

Bug Description

Two type of QoS policies can apply to a port:
- Port QoS policies: set directly on the port.
- Network QoS policies: those ones applied on the port's network.

If both are applied, port QoS policy must prevail over the network QoS policy (if both are different) [1].

To know if a rule must be applied on a port, a check is made in neutron/objects/qos/rule:QoSRule.should_apply_to_port. The logic currently implemented doesn't reflect what is documented in [1].

The expected result of test_should_apply_to_port_with_compute_port_and_net_policy must be False.

[1] https://docs.openstack.org/mitaka/networking-guide/config-qos.html

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
tags: added: qos
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/425280
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4ffeef246f3a73a3459583af7fcc55817a6ac1fc
Submitter: Jenkins
Branch: master

commit 4ffeef246f3a73a3459583af7fcc55817a6ac1fc
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jan 25 15:36:54 2017 +0000

    Enforce port QoS policies for all ports.

    This patch enforces the port QoS policies applied on all ports.
    Besides that, a port QoS policy must prevail over a network QoS
    policy, if both are present on the same port.

    Change-Id: Icccb835e48bb70ac1a08e0887ecb34160bec8cfa
    Closes-Bug: #1659312
    Closes-Bug: #1665282

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b1

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/462193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/462193
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=976af5591014145ffb066a756b984d8e31055da2
Submitter: Jenkins
Branch: stable/ocata

commit 976af5591014145ffb066a756b984d8e31055da2
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jan 25 15:36:54 2017 +0000

    Enforce port QoS policies for all ports.

    This patch enforces the port QoS policies applied on all ports.
    Besides that, a port QoS policy must prevail over a network QoS
    policy, if both are present on the same port.

    Change-Id: Icccb835e48bb70ac1a08e0887ecb34160bec8cfa
    Closes-Bug: #1659312
    Closes-Bug: #1665282
    (cherry picked from commit 4ffeef246f3a73a3459583af7fcc55817a6ac1fc)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.2

This issue was fixed in the openstack/neutron 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.