typo in neutron's defaults/main.yml

[t.goto]

I found a typo at neutron's defaults/main.yml which causes pull error.

Here's an excerpt from that file.

  neutron-sfc-agent:
    container_name: "neutron_sfc_agent"
    image: "{{ neutron_sfc_agent_image_full }}"
    enabled: "{{ neutron_plugin_agent == 'sfc' }}"
    privileged: True
    host_in_groups: >-
      {{
      True if orchestration_engine == 'KUBERNETES' else
      ( inventory_hostname in groups['compute'] or
      or (enable_manila | bool and inventory_hostname in groups['manila-share'])
      or inventory_hostname in groups['neutron-dhcp-agent']
      or inventory_hostname in groups['neutron-l3-agent']
      or inventory_hostname in groups['neutron-metadata-agent']
      and not enable_nova_fake | bool
      ) or
      ( inventory_hostname in groups['neutron-dhcp-agent']
      or inventory_hostname in groups['neutron-l3-agent']
      or inventory_hostname in groups['neutron-metadata-agent']
      and enable_nova_fake | bool
      )
      }}

The "or" at line "inventory_hostname in groups['compute'] or" is unnecessary.
I confirmed deleting unnecessary "or" solved this problem.

[t.goto (t.goto)]

Somehow review result doesn't automatically post here.
https://review.openstack.org/#/c/434641/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434641
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=79b4774e68b7f1533ed1156ecd4da9a21e3946fc
Submitter: Jenkins
Branch: master

commit 79b4774e68b7f1533ed1156ecd4da9a21e3946fc
Author: t.goto <email address hidden>
Date: Thu Feb 16 13:19:02 2017 +0900

    Fix typo in neutron's default/main.yml file

    There is an unnecessary condition operator in neutron's
    defaults/main.yml which causes pull error.

    - Delete an duplicated "or" from neutron-sfc-agent host_in_groups
     check condition.

    Change-Id: I32626ad83fbca9a17cd89b70ff95d58d23b200d2
    Closes-Bug: #1665188

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434750
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=7c727c88dffff68f026e97f1e47c85a1ac067744
Submitter: Jenkins
Branch: stable/ocata

commit 7c727c88dffff68f026e97f1e47c85a1ac067744
Author: t.goto <email address hidden>
Date: Thu Feb 16 13:19:02 2017 +0900

    Fix typo in neutron's default/main.yml file

    There is an unnecessary condition operator in neutron's
    defaults/main.yml which causes pull error.

    - Delete an duplicated "or" from neutron-sfc-agent host_in_groups
     check condition.

    Change-Id: I32626ad83fbca9a17cd89b70ff95d58d23b200d2
    Closes-Bug: #1665188
    (cherry picked from commit 79b4774e68b7f1533ed1156ecd4da9a21e3946fc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 4.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b2 development milestone.