Pre/Post puppet task resources only generated for Controller role

[James Slagle]

The pre and post puppet tasks (ControllerPrePuppet and ControllerPostPuppet) resources are only generated for a role specifically called Controller.

These resources are used to manage the pacemaker cluster during stack-update operations, by putting the cluster into maintenance mode, and restarting needed resources at the end of the update via pcs. So, it means you can't have any role running pacemaker services that isn't specifically called Controller.

This is an issue when using the deployed-server environment and custom roles. We have to use a custom role *not* named Controller so that we can set disable_constraints on the role, but we also need to have these task resources present so that we can do the needed operations on the pacemaker cluster during stack-updates.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/434451

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/434452

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434451
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=529768ae84f7713f2ae9447ff35ee2d63b4bdcd7
Submitter: Jenkins
Branch: master

commit 529768ae84f7713f2ae9447ff35ee2d63b4bdcd7
Author: James Slagle <email address hidden>
Date: Wed Feb 15 13:13:36 2017 -0500

    Generate Pre/Post Puppet Tasks for all roles

    We need to generate the Pre and Post Puppet Tasks for all roles, not
    just the Controller role. Otherwise, you have to have a role
    specifically named Controller that is running your pacemaker services,
    or pacemaker won't be properly handled on stack-updates.

    When using deployed-server's it's actually not possible to have a role
    called Controller, since we need to use all custom roles so that we can
    set disable_contraints on each role. Further, it is not possible to
    redefine the Controller role since puppet/controller-role.yaml is listed
    in the excludes file.

    Change-Id: I737b24db90932e292b50b122640f66385f2d1c23
    Partial-Bug: #1665060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434452
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f8cc35092d8d8c60eee12bd2a550ff5d60e28582
Submitter: Jenkins
Branch: master

commit f8cc35092d8d8c60eee12bd2a550ff5d60e28582
Author: James Slagle <email address hidden>
Date: Wed Feb 15 13:20:00 2017 -0500

    Add environment for deployed-server with pacemaker

    A new environment file to be used when using the deployed-server roles
    data at deployed-server/deployed-server-roles-data.yaml. This ensures
    the Pre and Post Puppet Tasks for the ControllerDeployedServer role are
    mapped to the stacks that handle maintenance mode and resource restarts
    for pacemaker on stack-update.

    Change-Id: I1ca52dfb3a3b669e128ebb0a28d9e36a1807faad
    Closes-Bug: #1665060

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/453830

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/453831

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/453831
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=40b4878fdcdc6f489760fc69bbae4b51a571f29e
Submitter: Jenkins
Branch: stable/ocata

commit 40b4878fdcdc6f489760fc69bbae4b51a571f29e
Author: James Slagle <email address hidden>
Date: Wed Feb 15 13:20:00 2017 -0500

    Add environment for deployed-server with pacemaker

    A new environment file to be used when using the deployed-server roles
    data at deployed-server/deployed-server-roles-data.yaml. This ensures
    the Pre and Post Puppet Tasks for the ControllerDeployedServer role are
    mapped to the stacks that handle maintenance mode and resource restarts
    for pacemaker on stack-update.

    Change-Id: I1ca52dfb3a3b669e128ebb0a28d9e36a1807faad
    Closes-Bug: #1665060
    (cherry picked from commit f8cc35092d8d8c60eee12bd2a550ff5d60e28582)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/453830
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=77aa9a71020157f21b8898958a6d472b6297ac36
Submitter: Jenkins
Branch: stable/ocata

commit 77aa9a71020157f21b8898958a6d472b6297ac36
Author: James Slagle <email address hidden>
Date: Wed Feb 15 13:13:36 2017 -0500

    Generate Pre/Post Puppet Tasks for all roles

    We need to generate the Pre and Post Puppet Tasks for all roles, not
    just the Controller role. Otherwise, you have to have a role
    specifically named Controller that is running your pacemaker services,
    or pacemaker won't be properly handled on stack-updates.

    When using deployed-server's it's actually not possible to have a role
    called Controller, since we need to use all custom roles so that we can
    set disable_contraints on each role. Further, it is not possible to
    redefine the Controller role since puppet/controller-role.yaml is listed
    in the excludes file.

    Change-Id: I737b24db90932e292b50b122640f66385f2d1c23
    Partial-Bug: #1665060
    (cherry picked from commit 529768ae84f7713f2ae9447ff35ee2d63b4bdcd7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.1.0 release.