Web Client: Item Summary - Recent Circ History - Checkin Workstation shows code when null

Bug #1665052 reported by Michele Morgan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.0
Fix Released
Undecided
Unassigned
3.1
Fix Released
Undecided
Unassigned

Bug Description

Evergreen Master

When viewing Recent Circ History tab in the Item Summary, if the Checkin Workstation field is null, it displays:

{{circ.checkin_workstation.name()}}

instead of a blank field.

Screenshot attached

Revision history for this message
Michele Morgan (mmorgan) wrote :
Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirmed on 2.12

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Still a problem in 3.0.1

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I created a branch to fix this. It's called user/sandbergja/lp1665052_correct_recent_circ_checkin_workstation

Here is a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1665052_correct_recent_circ_checkin_workstation

tags: added: pull
tags: added: pullrequest
removed: pull
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

P.S. Here are the testing instructions from the git commit:

1) Go to Item Status > Detail View > Recent Circ History for
an item that is currently checked out.
2) Note that the Checkin Workstation field says
"{{circ.checkin_workstation.name()}}"
3) Apply this commit.
4) Note that the Checkin Workstation field is empty if an
item is an item hasn't been checked in, but is filled with
the appropriate workstation name after it has been checked
in.

Revision history for this message
Ben Shum (bshum) wrote :

This worked for me. Pushed to master and backported for 3.1 and 3.0.

Changed in evergreen:
milestone: none → 3.2-rc
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.