cli role tests failed due to absent required property 'tags'

Bug #1664917 reported by Ilya Bumarskov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Ilya Bumarskov

Bug Description

cli tests for role have failed with following error:

2017-02-06 15:02:59 - ERROR - ssh_client.py:580 -- Command 'fuel role --rel 2 --create --file /tmp/create_role.yaml' returned exit code 1 while expected [0]
 STDOUT:

 STDERR:
400 Client Error: Bad Request for url: http://10.109.5.2:8000/api/v1/releases/2/roles/ ('tags' is a required property

Failed validating 'required' in schema['properties']['meta']:
    {'properties': {'conflicts': {'description': 'Specify which roles conflict this one.',
                                  'type': ['array', 'string']},
                    'description': {'description': 'Short description of role functionality',
                                    'type': 'string'},
                    'group': {'description': 'Name of a role group which reflects the role purpose in cloud or deployment process',
                              'enum': ['base',
                                       'compute',
                                       'storage',
                                       'other'],
                              'type': 'string'},
                    'has_primary': {'description': 'During orchestration this role will be splitted into primary-role and role.',
                                    'type': 'boolean'},
                    'limits': {'properties': {'condition': {'type': 'string'},
                                              'max': {'type': ['string',
                                                               'integer']},
                                              'min': {'type': ['string',
                                                               'integer']},
                                              'overrides': {'items': {'properties': {'condition': {'type': 'string'},
                                                                                     'max': {'type': ['string',
                                                                                                      'integer']},
                                                                                     'message': {'type': 'string'},
                                                                                     'min': {'type': ['string',
                                                                                                      'integer']},
                                                                                     'recommended': {'type': ['string',
                                                                                                              'integer']}},
                                                                      'required': ['condition'],
                                                                      'type': 'object'},
                                                            'minItems': 1,
                                                            'type': 'array'},
                                              'recommended': {'type': ['string',
                                                                       'integer']}},
                               'type': 'object'},
                    'name': {'description': 'Name that will be shown on UI',
                             'type': 'string'},
                    'public_ip_required': {'description': 'Specify if role needs public IP address.',
                                           'type': 'boolean'},
                    'restrictions': {'items': {'anyOf': [{'type': 'string'},
                                                         {'properties': {'action': {'type': 'string'},
                                                                         'condition': {'type': 'string'},
                                                                         'message': {'type': 'string'}},
                                                          'required': ['condition'],
                                                          'type': 'object'},
                                                         {'maxProperties': 1,
                                                          'minProperties': 1,
                                                          'type': 'object'}]},
                                     'minItems': 1,
                                     'type': 'array'},
                    'tags': {'items': {'type': 'string'},
                             'type': 'array'},
                    'update_once': {'description': 'Specified roles will be updated if current role added to cluster first time.',
                                    'type': 'array'},
                    'update_required': {'description': 'Specified roles will be selected for deployment, when a current role is selected.',
                                        'type': 'array'}},
     'required': ['name', 'description', 'tags'],
     'type': 'object'}

On instance['meta']:
    {u'conflicts': [u'controller', u'compute'],
     u'description': u'New role',
     u'name': u'Test role'})

To avoid it we should add "tags" property to yaml file with new role.

Changed in fuel:
importance: Undecided → High
assignee: nobody → Ilya Bumarskov (ibumarskov)
milestone: none → 10.1
tags: added: area-qa
Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/434187

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/434187
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=ea72b1d3e0289d2cd886876d5dd1d5a709b2316c
Submitter: Jenkins
Branch: stable/newton

commit ea72b1d3e0289d2cd886876d5dd1d5a709b2316c
Author: ibumarskov <email address hidden>
Date: Wed Feb 15 13:52:55 2017 +0400

    Add "tags" property for role templates

    Change-Id: Ia5e6a8d31687d86c0d803c392050fe7a40c56883
    Closes-bug: #1664917

tags: added: in-stable-newton
Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Ilya Bumarskov (ibumarskov) wrote :

Was verified on Fuel 10 build#1358

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/443475

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/443476

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/ocata)

Reviewed: https://review.openstack.org/443476
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=083465834d9ea0a1066dd657d4d7e5668fe2e6a8
Submitter: Jenkins
Branch: stable/ocata

commit 083465834d9ea0a1066dd657d4d7e5668fe2e6a8
Author: ibumarskov <email address hidden>
Date: Wed Feb 15 13:52:55 2017 +0400

    Add "tags" property for role templates

    Change-Id: Ia5e6a8d31687d86c0d803c392050fe7a40c56883
    Closes-bug: #1664917
    (cherry picked from commit ea72b1d3e0289d2cd886876d5dd1d5a709b2316c)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/443475
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=236f3a7bea496ab792e98378e74d1741b0151e9a
Submitter: Jenkins
Branch: master

commit 236f3a7bea496ab792e98378e74d1741b0151e9a
Author: ibumarskov <email address hidden>
Date: Wed Feb 15 13:52:55 2017 +0400

    Add "tags" property for role templates

    Change-Id: Ia5e6a8d31687d86c0d803c392050fe7a40c56883
    Closes-bug: #1664917
    (cherry picked from commit ea72b1d3e0289d2cd886876d5dd1d5a709b2316c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-qa ocata-eol

This issue was fixed in the openstack/fuel-qa ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.