[Telemetry-plugin] Cinder notification to ceilometer

[Vladislav Kuspits]

Detailed bug description:
Notifications of Cinder(whith lvm backend) doesn't work for ceilometer if use separate node (or you use Cinder on Compute node). However, it's works when use cinder on Controller node.
Telemetry plugin does not override default value [1] for notification driver. This default value depends on ceilometer['enabled'] option [2], and in case of deployment with plugin ceilometer hash in hiera looks like:

root@node-1:~# hiera ceilometer
{"alarm_history_time_to_live"=>"604800",
 "event_time_to_live"=>"604800",
 "metering_time_to_live"=>"604800",
 "http_timeout"=>"600",
 "notification_driver"=>"<SERVICE DEFAULT>",
 "db_password"=>"fmXOxtcrzpMhOI67HE0vYku6",
 "enabled"=>"true",
 "metering_secret"=>"uWsXx80vnIs2ComsMVd8MgzU",
 "user_password"=>"lq95aSKTDdNllZPXS6ex0nTk"}

but initial value of enabled parameter in astute.yaml is:

ceilometer:
  db_password: fmXOxtcrzpMhOI67HE0vYku6
  enabled: false
  metering_secret: uWsXx80vnIs2ComsMVd8MgzU
  user_password: lq95aSKTDdNllZPXS6ex0nTk

As you can see notification driver is SERVICE DEFAULT, because its value had been caculated before "enabled" parameter was overriden by plugin's hiera.pp manifest. This means after deployment notification_driver will be abcent in config. In order to fix this I recommend to set notification_driver explicitly to "messaging" in plugin's hiera manifest [1].

Steps to reproduce: Use cinder on a separate node from controller node.

Expected results: Samples for cinder volumes in ceilometer.

Actual result: Absence of the sample.

Workaround: Thats fix if add to /etc/cinder/cinder.conf notification_driver = messaging in [DEFAULT] section on Cinder node.

Impact: Ceilometer doesn't knows about volumes meters.

Description of the environment:
Fuel 9.1 whith all LMA plugins + telemetry plugin
OS: Ubuntu 14.04.5 LTS
Controller node
ELASTICSEARCH_KIBANA-INFLUXDB_GRAFANA node
2 Compute nodes
Compute-Cinder node
Network model: Neutron with VLAN segmentation.

[1] https://github.com/openstack/fuel-plugin-openstack-telemetry/blob/master/deployment_scripts/puppet/manifests/hiera.pp#L16

[2] https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/manifests/globals/globals.pp#L470