Tempest test "ShareServersAdminTest.test_show_share_server_details" is concurrency-prone

[Valeriy Ponomaryov]

Tempest test "ShareServersAdminTest.test_show_share_server_details" located in "manila_tempest_tests/tests/api/admin/test_share_servers.py" module is concurrency-prone.

It makes two actions [1], first one is getting list of share servers, second is getting details of first share server in list. It happens [2] that share server gets deleted between first and second calls because
test can pick up absolutely unrelated share server from some other parallel test. So, need to make this test use share server that is guaranteed to exist.

[1] https://github.com/openstack/manila/blob/44c186bc/manila_tempest_tests/tests/api/admin/test_share_servers.py#L203-L205

[2] http://logs.openstack.org/61/432261/1/gate/gate-manila-tempest-minimal-dsvm-dummy-ubuntu-xenial/0f6a7fd/logs/tempest_1/testr_results.html.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/433003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433003
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6e4e8fbfb4494a344ac342561ccad61514506a5c
Submitter: Jenkins
Branch: master

commit 6e4e8fbfb4494a344ac342561ccad61514506a5c
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Feb 13 13:25:38 2017 +0200

    [Tempest] Refactor api/tests/admin/test_share_servers module

    Doing following things:
     - Use ddt module removing code duplication.
     - Use v2 APIs instead of deprecated v1.
     - Use correct 'share_server_id' for
       'test_show_share_server_details' test to avoid concurrency issues.
       For more details, see closed b_u_g.

    Change-Id: If4d6029f2250e80c1eec0debb1b09a805d997028
    Closes-Bug: #1663865

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434289

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434289
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=40bbbfd8c608df06f48982bd801d3fe3dea2590e
Submitter: Jenkins
Branch: stable/ocata

commit 40bbbfd8c608df06f48982bd801d3fe3dea2590e
Author: Valeriy Ponomaryov <email address hidden>
Date: Mon Feb 13 13:25:38 2017 +0200

    [Tempest] Refactor api/tests/admin/test_share_servers module

    Doing following things:
     - Use ddt module removing code duplication.
     - Use v2 APIs instead of deprecated v1.
     - Use correct 'share_server_id' for
       'test_show_share_server_details' test to avoid concurrency issues.
       For more details, see closed b_u_g.
     - Use only 'active' status for listing servers with "status" filter.
       To avoid concurrency in case we pick server with different
       status than "active" and that may be changed before second call.

    This commit is combination of two cherry-pick'ed commits:
     - 6e4e8fbfb4494a344ac342561ccad61514506a5c
     - 46d499a85c0c40307172799a757193c50be0076f

    Change-Id: If4d6029f2250e80c1eec0debb1b09a805d997028
    Closes-Bug: #1663865

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.1 release.