Make quotes consistent in the sample config

Bug #1663624 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Michael Glaser

Bug Description

The sample config for the TripleO UI uses a mix of single and double-quotes.

As per the conventions in the rest of the project, these should all be single-quotes.

https://github.com/openstack/tripleo-ui/blob/master/config/tripleo_ui_config.js.sample

Bonus points for fixing the matching puppet template as well (and maybe updating it to add the missing comments and defaults from the sample while at it).

https://github.com/openstack/puppet-tripleo/blob/master/templates/ui/tripleo_ui_config.js.erb

Julie Pichon (jpichon)
description: updated
Changed in tripleo:
assignee: nobody → Michael Glaser (mikeg451)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432401

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432406

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/432401
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=4b1ff36d5a79dcf6a4567cacae4de30fcc46d32a
Submitter: Jenkins
Branch: master

commit 4b1ff36d5a79dcf6a4567cacae4de30fcc46d32a
Author: MikeG451 <email address hidden>
Date: Fri Feb 10 17:31:41 2017 +0000

    Make quotes consistent in the sample config

    Per project conventions, should use single quotes.

    Change-Id: Icc7093a3dfbad125d9514c1c1a094183f44a67e4
    Partial-Bug: #1663624

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/432406
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=0a44474b55a96fa90b58cbdf006139ba8aa27cc0
Submitter: Jenkins
Branch: master

commit 0a44474b55a96fa90b58cbdf006139ba8aa27cc0
Author: MikeG451 <email address hidden>
Date: Fri Feb 10 17:50:26 2017 +0000

    Make quotes consistent to match the sample config

    Per project conventions, should use single quotes.
    Also, update comments and defaults to match sample.

    Change-Id: I82ddcec230e7a03965d753db60968912b8d7da5c
    Closes-Bug: #1663624

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.2.0

This issue was fixed in the openstack/puppet-tripleo 6.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.