mixxx-2.1.0-alpha fails to install on Win10

[Daniel Schürmann]

I have just tested
mixxx-2.1.0-alpha-pre-master-git6193-release-x64.msi
on Win10

But it fails.

Befor it was complaining about an old Mixxx setup. Ihave deinstalled it and now I see the attached message box.

[Daniel Schürmann (daschuer)]

After downloading and installing vc_redist.x64.exe for VS 2015, the setup runs as espected.

[Sébastien BLAISOT (sblaisot)]

yes, this is a known issue. I dont already know why this happens and didn't see it with vs 2013.
I'll take a look at that maybe this weekend

[GJ (gj23)]

Do you have User Account Control set to "Never Notify"? This will cause the install to fail on Win 8.1.

[Daniel Schürmann (daschuer)]

This just happens to me again using Win 7

[Daniel Schürmann (daschuer)]

vc_redist.x86.exe in this 32 bit system does not help.

[Be (be.ing)]

> vc_redist.x86.exe in this 32 bit system does not help.

Did you use the VS 2013 or VS 2015 redistributable runtime? A user on the forum reported to me via private message that installing the VS 2015 redistributable runtime let him install a recent master build that did not work before. Should we include the runtime in our Windows packages?

[Sébastien BLAISOT (sblaisot)]

the runtime isntaller is included in the windows install package.It fails to install and that's the cause mix don't install properly.
I need to work on a complete installer redisign to fix I but didn't have the time to work on it for now.

[Daniel Schürmann (daschuer)]

Can you outline the steps to do, that one else can jump in? This is IMHO a
critical bug for release.

Am 29.06.2017 10:01 vorm. schrieb "Sébastien BLAISOT" <<email address hidden>
>:

> the runtime isntaller is included in the windows install package.It fails
> to install and that's the cause mix don't install properly.
> I need to work on a complete installer redisign to fix I but didn't have
> the time to work on it for now.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1663380
>
> Title:
> mixxx-2.1.0-alpha fails to install on Win10
>
> Status in Mixxx:
> Confirmed
>
> Bug description:
> I have just tested
> mixxx-2.1.0-alpha-pre-master-git6193-release-x64.msi
> on Win10
>
> But it fails.
>
> Befor it was complaining about an old Mixxx setup. Ihave deinstalled
> it and now I see the attached message box.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1663380/+subscriptions
>

[Sébastien BLAISOT (sblaisot)]

1. update my build env to MSVS 2015 : done
2. compile a recente version : in progress
3. transform the MSI with msvc runtime embedded to a bundle
http://wixtoolset.org/documentation/manual/v3/bundle/

I'm back on this now.

[Sébastien BLAISOT (sblaisot)]

I'm working on this one, so changing state to "In progress".
I expect to provide a PR before the end of the weekend.

[Sébastien BLAISOT (sblaisot)]

https://github.com/mixxxdj/mixxx/pull/1306

[Sébastien BLAISOT (sblaisot)]

Windows users tests required:
1. uninstall Mixxx
2. Uninstall all MS visual C++ 2015 redistributables (x86 and x64)
3. Download https://ci.appveyor.com/project/mixxxdj/mixxx/build/master-2100/job/skpt4a9wlv0fa12y/artifacts
4. try to install

please let me know if this works

[Daniel Schürmann (daschuer)]

The X64 build installs the x86 Redistibutable win Win 10 x64.
The installation succeeds, but Mixxx cannot be started.
Installing the x64 version manual works.

[Daniel Schürmann (daschuer)]

On WinXP x86 everything works like a charm.

[Sébastien BLAISOT (sblaisot)]

Damned, broken logic. Copy/past error.

if x86
  install x86 redistributable
else
  install x86 redistributable

Fixed in https://github.com/mixxxdj/mixxx/pull/1306/commits/df6ea223a7cc18f3b3b6614cec3daf79287ff5b3

I'll post here new artifact when ready

[Sébastien BLAISOT (sblaisot)]

You can try the following installers that should address 64 bits bug :

32 bits : https://ci.appveyor.com/api/buildjobs/7ic5pajniqgqigbu/artifacts/mixxx-2.1.0-alpha-pre-master-PR1306-git6320-release-x86.exe
64 bits: https://ci.appveyor.com/api/buildjobs/nej2gw6sbxcrount/artifacts/mixxx-2.1.0-alpha-pre-master-PR1306-git6320-release-x64.exe

please also report if uninstalling work fine :
- do you still have c++ redist under add/remove programs after uninstalling ?
- do you still have Mixxx under add/remove programs after uninstalling ?
- do you still have Mixxx.exe in "program files\Mixxx" after unisntalling ?

I'm now working on UI polishing and localization.

[Ambrosio Barceló (bronxio)]

On Windows 7 SP1 64-bit (with last Windows updates), I tested that last 64-bit version from sblaisot (PR1306-git6320) with MSVC 2015 runtime already installed and it worked fine (and opened with no problem at all). I had installed Mixxx 2.0.0 before, but it was already uninstalled when I installed this.

Uninstall information:
- do you still have c++ redist...? Yes, but I had already installed this one before the installation: https://www.microsoft.com/es-ES/download/details.aspx?id=48145
- do you still have Mixxx under add/remove...? No, it's gone.
- do you still have Mixxx.exe in "program files\Mixxx"...? Yes, it's still there (attached photo with remaining files)

If you want more info about my pc, do not hesitate to ask for it.

[Daniel Schürmann (daschuer)]

Uninstall on WinXP and Win10 Version git6315 runs, but files are still there. I have deleted these files an installed git6320

The installation of Win10 X64 version runs fine. Unintsall still does not manage to install any file.

The x64 Setup starts on my 32 bit WinXP and quits after VC2015 x64 installation fails, it should quit more early.

The x86 version runs but pops up this message:
"Installer was not able to find MIcrosoft Visual C++ 2015 Redistributable on this system. This is likely an installer bug and should be reported to Mixxx developpers"

It is a false positive, because VC2015 was just installed and is shown in the apps list.
Repeated call of the installer does not change the issue here is a log file.

[05CC:0E38][2017-07-12T20:44:58]i001: Burn v3.11.0.1701, Windows v5.1 (Build 2600: Service Pack 3), path: C:\DOKUME~1\Besitzer\LOKALE~1\Temp\{0DCE8EDE-640C-49EC-AD46-5E5916E22EB1}\.cr\mixxx-2.1.0-alpha-pre-master-PR1306-git6320-release-x86.exe
[05CC:0E38][2017-07-12T20:44:58]i009: Command Line: '-burn.clean.room=D:\Downloads\mixxx-2.1.0-alpha-pre-master-PR1306-git6320-release-x86.exe -burn.filehandle.attached=368 -burn.filehandle.self=364'
[05CC:0E38][2017-07-12T20:44:58]i000: Setting string variable 'WixBundleOriginalSource' to value 'D:\Downloads\mixxx-2.1.0-alpha-pre-master-PR1306-git6320-release-x86.exe'
[05CC:0E38][2017-07-12T20:44:58]i000: Setting string variable 'WixBundleOriginalSourceFolder' to value 'D:\Downloads\'
[05CC:0E38][2017-07-12T20:44:58]i000: Setting string variable 'WixBundleLog' to value 'C:\DOKUME~1\Besitzer\LOKALE~1\Temp\Mixxx_20170712204458.log'
[05CC:0E38][2017-07-12T20:45:13]i000: Setting string variable 'WixBundleName' to value 'Mixxx'
[05CC:0E38][2017-07-12T20:45:13]i000: Setting string variable 'WixBundleManufacturer' to value 'The Mixxx Development Team'
[05CC:0808][2017-07-12T20:45:13]i000: Setting numeric variable 'WixStdBALanguageId' to value 1033
[05CC:0808][2017-07-12T20:45:13]i000: Setting version variable 'WixBundleFileVersion' to value '2.1.0.6320'
[05CC:0E38][2017-07-12T20:45:13]i100: Detect begin, 2 packages
[05CC:0E38][2017-07-12T20:45:13]w120: Detected partially cached package: vcredist, invalid payload: vcredist, reason: 0x80070002
[05CC:0E38][2017-07-12T20:45:13]i103: Detected related package: {8225FCD4-DFE8-45D8-9BFA-8DBD0AC23135}, scope: PerMachine, version: 2.1.0.6315, language: 0 operation: MajorUpgrade
[05CC:0E38][2017-07-12T20:45:13]i101: Detected package: vcredist, state: Absent, cached: Partial
[05CC:0E38][2017-07-12T20:45:13]i101: Detected package: MainPackage, state: Absent, cached: None
[05CC:0E38][2017-07-12T20:45:13]i199: Detect complete, result: 0x0
[05CC:0808][2017-07-12T20:45:36]i000: Setting numeric variable 'EulaAcceptCheckbox' to value 0
[05CC:0E38][2017-07-12T20:45:36]i200: Plan begin, 2 packages, action: Install
[05CC:0E38][2017-07-12T20:45:36]w321: Skipping dependency registration on package with no dependency providers: vcredist
[05CC:0E38][2017-07-12T20:45:36]i000: Setting string variable 'WixBundleLog_vcredist' to value 'C:\DOKUME~1\Besitzer\LOKALE~1\Temp\Mixxx_20170712204458_000_vcredist.log'
[05CC:0E38][2017-07-12T20:45:36]i000: Setting string variable...

[Sébastien BLAISOT (sblaisot)]

Thanks you so much Ambrosio and Daniel for your tests.

* Uninstall with git6315 not working well : hopefully have been corrected with https://github.com/mixxxdj/mixxx/pull/1306/commits/df6ea223a7cc18f3b3b6614cec3daf79287ff5b3

* Uninstall with git6320 should work... but as you installed git6315 before and it was not properly uninstalled, windows keep thinking it is installed even if you removed the files. Unlike previous NSIS installer, there are not only files in INSTALLDIR, but also registry entries and files in Mixxx MSI cache.
Can you please launch git6320 or later installer.exe with /uninstall parameter and paste the log you can find in %TEMP% ? Maybe there is an issue left but I'm not sure.

* x64 setup on win32 : not handled currently. I updated PR todo list and will correct that.

* x86 installer not detecting vcredist : was it on win XP 32 or win XP 64 ? can you confirm in your registry you have a key under HKLM\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\14.0\VC\Runtimes\ ?
Nevermind, It seems I forgot a "NOT" under installcondition : block install if vcredist NOT found ;)
should be fixed by https://github.com/mixxxdj/mixxx/pull/1306/commits/5af1279858cb4609be9edc7c199bcbabb69a6c4e

[Sébastien BLAISOT (sblaisot)]

installing 64bits Mixxx on 32bits OS : fixed in https://github.com/mixxxdj/mixxx/pull/1306/commits/277c286a29e49c10f29591051210c336982726e0

latest installer is available in https://ci.appveyor.com/project/mixxxdj/mixxx/build/master-2137

[Daniel Schürmann (daschuer)]

WinXP 32bit runs through. The x64 installer exits early.
Uninstall still fails.

Win10 x64bit setup fails now with this message:
"Installer was not able to find MIcrosoft Visual C++ 2015 Redistributable on this system. This is likely an installer bug and should be reported to Mixxx developpers"

Log:
[1F7C:1F80][2017-07-13T21:46:50]i001: Burn v3.11.0.1701, Windows v10.0 (Build 15063: Service Pack 0), path: C:\Users\dasch\AppData\Local\Temp\{8F2F9030-D226-4611-8684-08D41FEE62A3}\.cr\mixxx-2.1.0-alpha-pre-master-PR1306-git6321-release-x64.exe
[1F7C:1F80][2017-07-13T21:46:50]i009: Command Line: '-burn.clean.room=\\VBOXSVR\daniel\Downloads\mixxx-2.1.0-alpha-pre-master-PR1306-git6321-release-x64.exe -burn.filehandle.attached=536 -burn.filehandle.self=544'
[1F7C:1F80][2017-07-13T21:46:50]i000: Setting string variable 'WixBundleOriginalSource' to value '\\VBOXSVR\daniel\Downloads\mixxx-2.1.0-alpha-pre-master-PR1306-git6321-release-x64.exe'
[1F7C:1F80][2017-07-13T21:46:50]i000: Setting string variable 'WixBundleOriginalSourceFolder' to value '\\VBOXSVR\daniel\Downloads\'
[1F7C:1F80][2017-07-13T21:46:51]i000: Setting string variable 'WixBundleLog' to value 'C:\Users\dasch\AppData\Local\Temp\Mixxx_20170713214651.log'
[1F7C:1F80][2017-07-13T21:46:51]i000: Setting string variable 'WixBundleName' to value 'Mixxx'
[1F7C:1F80][2017-07-13T21:46:51]i000: Setting string variable 'WixBundleManufacturer' to value 'The Mixxx Development Team'
[1F7C:1F90][2017-07-13T21:46:51]i000: Setting version variable 'WixBundleFileVersion' to value '2.1.0.6321'
[1F7C:1F80][2017-07-13T21:46:51]i100: Detect begin, 2 packages
[1F7C:1F80][2017-07-13T21:46:51]i103: Detected related package: {5BF0247E-9D3C-45EF-9E10-2F7C5EA3886A}, scope: PerMachine, version: 2.1.0.6320, language: 0 operation: MajorUpgrade
[1F7C:1F80][2017-07-13T21:46:51]i101: Detected package: vcredist64, state: Absent, cached: None
[1F7C:1F80][2017-07-13T21:46:51]i101: Detected package: MainPackage, state: Absent, cached: None
[1F7C:1F80][2017-07-13T21:46:51]i052: Condition 'VersionNT64' evaluates to true.
[1F7C:1F80][2017-07-13T21:46:51]i199: Detect complete, result: 0x0
[1F7C:1F80][2017-07-13T21:46:54]i200: Plan begin, 2 packages, action: Install
[1F7C:1F80][2017-07-13T21:46:54]w321: Skipping dependency registration on package with no dependency providers: vcredist64
[1F7C:1F80][2017-07-13T21:46:54]i000: Setting string variable 'WixBundleLog_vcredist64' to value 'C:\Users\dasch\AppData\Local\Temp\Mixxx_20170713214651_000_vcredist64.log'
[1F7C:1F80][2017-07-13T21:46:54]i000: Setting string variable 'WixBundleRollbackLog_MainPackage' to value 'C:\Users\dasch\AppData\Local\Temp\Mixxx_20170713214651_001_MainPackage_rollback.log'
[1F7C:1F80][2017-07-13T21:46:54]i000: Setting string variable 'WixBundleLog_MainPackage' to value 'C:\Users\dasch\AppData\Local\Temp\Mixxx_20170713214651_001_MainPackage.log'
[1F7C:1F80][2017-07-13T21:46:54]i201: Planned package: vcredist64, state: Absent, default requested: Present, ba requested: Present, execute: Install, rollback: None, cache: Yes, uncache: Yes, dependency: None
[1F7C:1F80][2017-07-13T21:46:54]i201: Planned package: MainPackage, state: Absent, default requested: Prese...

[Sébastien BLAISOT (sblaisot)]

wow, that's weird.

so, 2 things:

1) for uninstall problems, it's strange. probably related to an older version with a bad product code still installed.
Using Powershell, list all installed products
get-wmiobject Win32_Product | Where-Object {$_.Name -like "*mixxx*"} | Format-Table IdentifyingNumber, Name
then manually uninstall by productcode with
msiexec /x {INSERT_GUID_HERE}
after all older mixxx have been uninstalled, you can safely remove left files and try again.

2) for the installation problem on x64, the culprit is https://github.com/mixxxdj/mixxx/pull/1306/commits/5af1279858cb4609be9edc7c199bcbabb69a6c4e
I reverted it. Next build should be find on this side.

[Sébastien BLAISOT (sblaisot)]

hummm, as I reverted, isntalling x86 on 32bits XP should not work again. I think there is a detection mismatch. I will work on that.

[Sébastien BLAISOT (sblaisot)]

ok, this build should be better: https://ci.appveyor.com/project/mixxxdj/mixxx/build/master-2150

[Sébastien BLAISOT (sblaisot)]

most issues, including uninstallation, should be addressed here: https://ci.appveyor.com/project/mixxxdj/mixxx/build/master-2183

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8799