[regression] mir_demo_standalone_render_surfaces fails to start (std::exception::what: cannot find buffer by id)

[Daniel van Vugt]

$ sudo mir_demo_standalone_render_surfaces

Rendering 5 surfaces
ERROR: /build/mir-1Sl_GZ/mir-0.26.0+17.04.20170126.3/src/server/compositor/buffer_map.cpp(105): Throw in function std::map<mir::IntWrapper<mir::graphics::BufferIdTag, unsigned int>, mir::compositor::BufferMap::MapEntry>::iterator mir::compositor::BufferMap::checked_buffers_find(mir::graphics::BufferID, const std::unique_lock<std::mutex>&)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::logic_error> >
std::exception::what: cannot find buffer by id

[Daniel van Vugt (vanvugt)]

Bisected. The regression started in:

------------------------------------------------------------
revno: 3941 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Mon 2017-01-16 14:04:32 +0000
message:
  server: remove mg::BufferProperties in some interfaces. mg::BufferProperties is problematic because it contains mg::BufferUsage, an outdated concept now that we have platform-specific extensions.
  .

  Approved by mir-ci-bot, Alan Griffiths, Cemil Azizoglu.
------------------------------------------------------------

[Daniel van Vugt (vanvugt)]

Happening on krillin too, with the latest lp:mir -

Rendering 5 surfaces
ERROR: /home/dan/bzr/mir/trunk/src/server/compositor/buffer_map.cpp(114): Throw in function std::map<mir::IntWrapper<mir::graphics::BufferIdTag, unsigned int>, mir::compositor::BufferMap::MapEntry>::const_iterator mir::compositor::BufferMap::checked_buffers_find(mir::graphics::BufferID, const std::unique_lock<std::mutex>&) const
Dynamic exception type: N5boost16exception_detail10clone_implINS0_19error_info_injectorISt11logic_errorEEEE
std::exception::what: cannot find buffer by id

[Alan Griffiths (alan-griffiths)]

This program has outlived its usefulness. The approach it uses doesn't work because we've restructured the code, and we do not recommend doing this.

[Mir CI Bot (mir-ci-bot)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.28.0