Allow getting vars in list query result with details=all

Bug #1662618 reported by Sulochan Acharya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
craton
Fix Released
High
Sulochan Acharya

Bug Description

When querying for hosts with filters we only give host details in the response and not the variables itself. This is to guard against loading vars for large response. However, users like to have vars for certain query, we should provide a filter such that we can get vars back:

/v1/hosts?region_id=1&name=xyg&details=all

where details = all will fetch all details including vars.

[18:20] <sulo> jimbaker: +1
[18:22] <jimbaker> sulo, when we add namespace support, we can also push the namespace filtering into this query as well. natural extension
[18:22] <jimbaker> maybe it would be a specification of details? TBD
[18:23] <jimbaker> sulo, what if we say ?...&details=all
[18:23] <sulo> vs details= ??
[18:23] <jimbaker> vs details=true
[18:23] <sulo> you thinking ther can be other params to details
[18:23] <jimbaker> exactly, such as the specific namespaces to be imported
[18:23] <sulo> yeah i mean its the same as saying details=true
[18:23] <sulo> gotcha
[18:24] <sulo> sounds good to me

Jim Baker (jimbaker)
summary: - Allow getting vars in list query result with details=true
+ Allow getting vars in list query result with details=all
Changed in craton:
importance: Undecided → High
Revision history for this message
Jim Baker (jimbaker) wrote :
Jim Baker (jimbaker)
description: updated
Changed in craton:
milestone: none → v0.1.0
assignee: nobody → Sulochan Acharya (sulochan-acharya)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to craton (master)

Fix proposed to branch: master
Review: https://review.openstack.org/437905

Changed in craton:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to craton (master)

Reviewed: https://review.openstack.org/437905
Committed: https://git.openstack.org/cgit/openstack/craton/commit/?id=2a5f24fa7d87f1dca07631adb58b0ce32339f8a6
Submitter: Jenkins
Branch: master

commit 2a5f24fa7d87f1dca07631adb58b0ce32339f8a6
Author: Sulochan Acharya <email address hidden>
Date: Fri Feb 24 13:56:28 2017 +0000

    Allow getting vars on get all resouce call

    - This patch adds a new parameter `details` as query
    parameter such that, when doing a list call on any
    resource we can do ?details=all to get the variables
    associated with the particualr resource.

    Closes Bug: 1662618

    Change-Id: Ic8423e30ca05d265ca6419fa179d5569a1995e3e

Changed in craton:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.