no check audit state when updating audit state

[Hidekazu Nakamura]

we can update audit state other than audit state machine is defined as of now.
we should check audit state when updating existing audit.

[aditi sharma (adi-sky17)]

we need to impose same validation check as imposed for action plan
https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action_plan.py#L493
with reference to audit state machine http://docs.openstack.org/developer/watcher/_images/audit_state_machine.png

[Hidekazu Nakamura (nakamura-h)]

thanks, aditi.

I already proposed code, which is not displayed here.
https://review.openstack.org/#/c/429995/
but i did not see validation check of action plan you checked.

[aditi sharma (adi-sky17)]

@Hidekazu just follow the link
https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action_plan.py#L493
there are allowed patch transitions for action plan, otherwise what you have propsed is also doing the same thing.

Thanks for the patch

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429995
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=0d83354c5740bd9b63ec126383da03bd16ab5427
Submitter: Jenkins
Branch: master

commit 0d83354c5740bd9b63ec126383da03bd16ab5427
Author: Hidekazu Nakamura <email address hidden>
Date: Tue Feb 7 11:39:28 2017 +0900

    Add checking audit state

    This patch adds checking audit state when updating an existing audit
    in accordance with audit state machine.

    Closes-Bug: #1662406

    Change-Id: I20610c83169b77f141974a5cebe33818a4bf0728

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434901

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434901
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=ed3224835aea5f184c1e6941563854a77f0621b5
Submitter: Jenkins
Branch: stable/ocata

commit ed3224835aea5f184c1e6941563854a77f0621b5
Author: Hidekazu Nakamura <email address hidden>
Date: Tue Feb 7 11:39:28 2017 +0900

    Add checking audit state

    This patch adds checking audit state when updating an existing audit
    in accordance with audit state machine.

    Closes-Bug: #1662406

    Change-Id: I20610c83169b77f141974a5cebe33818a4bf0728
    (cherry picked from commit 0d83354c5740bd9b63ec126383da03bd16ab5427)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 1.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 1.1.0 release.