malformed json when result is transferred to state_info

[Winson Chan]

Given a dict in the task result, the double quotes are removed from the state info leading to a malformed json.

vagrant@arkham:~/st2$ mistral task-get-result 24231044-046e-4b27-b738-e031372b4d5d
{
    "error": "Execution canceled by user."
}

vagrant@arkham:~/st2$ mistral task-get 24231044-046e-4b27-b738-e031372b4d5d
+---------------+--------------------------------------+
| Field | Value |
+---------------+--------------------------------------+
| ID | 24231044-046e-4b27-b738-e031372b4d5d |
| Name | task1 |
| Workflow name | examples.mistral-test-cancel |
| Execution ID | 19d2e289-bab1-41d4-bc4c-4cc7bba71e91 |
| State | ERROR |
| State info | {error: Execution canceled by user.} |
| Created at | 2017-02-06 22:01:45 |
| Updated at | 2017-02-06 22:01:49 |
+---------------+--------------------------------------+

[Anastasia Kuznetsova (akuznetsova)]

Hello Winson,

Can you help me a little bit?
I can't reproduce such case:
- I can get result in a dict format, but task status is SUCCESS and state_info is None
- I can reproduce situation when task status is ERROR, but state_info is not a dict.

So I am trying to use CANCEL feature like you've used, I think.
Here is my wf:
---
version: "2.0"

wf:
  type: direct
  tasks:
    never_ending_task:
      action: std.sleep seconds=60

I do following:
mistral workflow-create wf.yaml
mistral execution-create wf
mistral execution-update -s CANCELLED <id>

Wf goes to CANCELLED status, but TASK is still RUNNING, so I can't get message like in the description. As for me it looks like a bug.

Could you please provide your steps?

[Winson Chan (winson-c-chan)]

I don't think you'll need to test w/ cancel. How about writing a test workflow with a task that runs an asynchronous and then update the task w/ an error and additional info which contains JSON?

[Hardik Jasani (hjasani)]

Minimal workflow to reproduce bug:

---
version: "2.0"

minimal_wf:
  type: direct
  tasks:
    main_task:
      action: std.test_dict
      input:
        size: 1
        key_prefix: "abc"
        val: "pqr"
      on-success:
        - fail msg="<% task().result %>"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/559729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/559729
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=6de2c15e6ac99a100478230e26af945beb1439f9
Submitter: Zuul
Branch: master

commit 6de2c15e6ac99a100478230e26af945beb1439f9
Author: hardikj <email address hidden>
Date: Mon Apr 9 18:23:29 2018 +0530

    Fix malformed state_info when json is set to it

    Fix bug where setting a dict to state_info did not convert to
    JSON format properly.

    Change-Id: Ib78d65483dd628e03de2484d3176ab7f275bc9d6
    Closes-bug: #1662350

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 7.0.0.0b1 development milestone.