Problems when switching from v3 rc file to undercloud stackrc

[Ben Nemec]

At the moment, the stackrc file generated for the undercloud is v2 only. This means it doesn't set things like OS_PROJECT_NAME. This can cause problems when switching from a v3 rc file (such as the one we generate for the overcloud) back to stackrc.

I think the first thing we should do is implement a change like https://review.openstack.org/#/c/347553/ for the undercloud. That will prevent any variables from another rc file from polluting the environment when we source stackrc.

A v3 stackrc would be a separate work item to be done at some point in the future.

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1418828

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428821

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428821
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=03d5cd9a17525ea44dd2c69d2d95b75c3b7f4c0d
Submitter: Jenkins
Branch: master

commit 03d5cd9a17525ea44dd2c69d2d95b75c3b7f4c0d
Author: Ben Nemec <email address hidden>
Date: Fri Feb 3 17:11:18 2017 +0000

    Clear any previous environment in stackrc

    As was done in I6badc5864426a371323a59100155e1c284af84b8 for the
    overcloud. This is particularly a problem because right now we
    only generate a v2 stackrc file, and if you switch from a v3
    overcloudrc to the v2 stackrc you'll have v3 env vars left over in
    the environment, which will likely break client usage.

    Given that it's late in the cycle, I think this is the safest
    change to make. Adding v3 settings to stackrc can be a followup
    in Pike.

    Change-Id: I2ba3160656372fd73d51cfbe9de8f49dc983009d
    Closes-Bug: 1661689

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/429699

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 6.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/479033

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/479033
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a9b96d295ed16f545d8ba062e8196ba25803c408
Submitter: Jenkins
Branch: stable/newton

commit a9b96d295ed16f545d8ba062e8196ba25803c408
Author: Ben Nemec <email address hidden>
Date: Fri Feb 3 17:11:18 2017 +0000

    Clear any previous environment in stackrc

    As was done in I6badc5864426a371323a59100155e1c284af84b8 for the
    overcloud. This is particularly a problem because right now we
    only generate a v2 stackrc file, and if you switch from a v3
    overcloudrc to the v2 stackrc you'll have v3 env vars left over in
    the environment, which will likely break client usage.

    Given that it's late in the cycle, I think this is the safest
    change to make. Adding v3 settings to stackrc can be a followup
    in Pike.

    Change-Id: I2ba3160656372fd73d51cfbe9de8f49dc983009d
    Closes-Bug: 1661689
    (cherry picked from commit 03d5cd9a17525ea44dd2c69d2d95b75c3b7f4c0d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 5.3.1 release.