typo in cinder role's pull.yml

Bug #1660961 reported by t.goto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
Eduardo Gonzalez

Bug Description

ansible/role/cinder/task/pull.yml has typo which errors like following.

TASK [cinder : include] ********************************************************
fatal: [192.168.1.102]: FAILED! => {"failed": true, "reason": "Syntax Error while loading YAML.\n\n\nThe error appears to have been in '/usr/share/kolla/ansible/roles/cinder/tasks/pull.yml': line 10, column 4, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n - item.value.enabled | bool\n with_dict: \"{{ cinder_services }}\"\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}
 to retry, use: --limit @/usr/share/kolla/ansible/site.retry

---
- name: Pulling cinder images
  kolla_docker:
    action: "pull_image"
    common_options: "{{ docker_common_options }}"
    image: "{{ item.value.image }}"
  when:
    - inventory_hostname in groups[item.value.group]
    - item.value.enabled | bool
   with_dict: "{{ cinder_services }}"

Last line has a unnecessary space before "with_dict".

Revision history for this message
t.goto (t.goto) wrote :

I wonder why gate-* didn't notice this.
Are you using some intelligence parser or linter?

Revision history for this message
Eduardo Gonzalez (egonzalez90) wrote :

Gates don't do kolla-ansible pull, when deploying the docker run command will pull the images.

Changed in kolla-ansible:
assignee: nobody → Eduardo Gonzalez (egonzalez90)
importance: Undecided → High
status: New → In Progress
milestone: none → ocata-rc1
Revision history for this message
t.goto (t.goto) wrote :

That figures.
Thank you for clearing up :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/427737
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=485ded5ba3d7f9834f7f0b0a5e085ed5211c233f
Submitter: Jenkins
Branch: master

commit 485ded5ba3d7f9834f7f0b0a5e085ed5211c233f
Author: Eduardo Gonzalez <email address hidden>
Date: Wed Feb 1 14:31:52 2017 +0000

    Fix pull syntax error in cinder

    Change-Id: I548cb6cbc718864cffb95b73376a3e138eef0a6d
    Closes-Bug: #1660961

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 4.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.