Wrong timezone in settings page

Bug #1660648 reported by Mateusz Kowalski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Mateusz Kowalski

Bug Description

When new user (=clean cookies) logs into Horizon, in Settings page "UTC" is always shown even if the local_settings indicate another timezone. At the same time all the dates are shown in the real timezone (=the one from local settings).

Whole procedure to reproduce:

* set local_settings to TIME_ZONE = "Europe/Zurich" (=UTC+1)
* clear the cookies
* log into dashboard and check value (=label) is set to UTC
* check some random date in UI (like instance creation time)
* go to the settings and change value to UTC+1
* check the same date in UI and notice it hasn't changed
* go to the settings and change value back to UTC
* check the same date one more time and notice the value has now changed

It means only the initial value is wrong. As tz is stored in cookie, after user changes it for the first time in the current session (=cookie lifecycle) everything is shown correctly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/427601

Changed in horizon:
assignee: nobody → Mateusz Kowalski (makowals)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/427601
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=18bd068ef1d754f7ebd394954ccb68cd9bcbad89
Submitter: Jenkins
Branch: master

commit 18bd068ef1d754f7ebd394954ccb68cd9bcbad89
Author: Mateusz Kowalski <email address hidden>
Date: Wed Feb 1 10:05:29 2017 +0100

    Fix ignored timezone value from local_settings

    When django_timezone not set in session or cookie,
    default value is taken from the settings file but in there
    has to be looked as TIME_ZONE

    Change-Id: Idf93084f654ab65a2ed0dba7bc583147210cf175
    Closes-bug: #1660648

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/430178

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/430178
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=74c55059d74459b75d117cb4faf979f79885318d
Submitter: Jenkins
Branch: stable/ocata

commit 74c55059d74459b75d117cb4faf979f79885318d
Author: Mateusz Kowalski <email address hidden>
Date: Wed Feb 1 10:05:29 2017 +0100

    Fix ignored timezone value from local_settings

    When django_timezone not set in session or cookie,
    default value is taken from the settings file but in there
    has to be looked as TIME_ZONE

    Change-Id: Idf93084f654ab65a2ed0dba7bc583147210cf175
    Closes-bug: #1660648
    (cherry picked from commit 18bd068ef1d754f7ebd394954ccb68cd9bcbad89)

tags: added: in-stable-ocata
Changed in horizon:
milestone: none → pike-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0rc2

This issue was fixed in the openstack/horizon 11.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.