subsequent snapshot access rules always go to error state when one rule is in error

[Rodrigo Barbieri]

Whenever adding snapshot access rules to a mountable snapshot, if one rule is in error, all subsequent rules will be in error for drivers that always look at "access_rules" parameter. Error'ed rules should not be passed down to drivers in subsequent snapshot-access-allow calls.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/426896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426896
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4f330330d59739ec6549a1d83096e8334e8bbe0c
Submitter: Jenkins
Branch: master

commit 4f330330d59739ec6549a1d83096e8334e8bbe0c
Author: Rodrigo Barbieri <email address hidden>
Date: Mon Jan 30 15:56:03 2017 -0200

    Fix error'ed access rules being sent to driver

    Error'ed snapshot access rules should not be sent down to drivers,
    as drivers that only look at 'access_rules' parameter will always
    try to apply them, causing every subsequent call to result in
    error. They should only be sent to drivers when being removed.

    Change-Id: Icf7e87d82eb0d51d441cd813da146cc0965fa334
    Closes-bug: #1660425

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.0.0rc1 release candidate.