regression in linux-libc-dev in yakkety: C++ style comments are not allowed in ISO C90

Bug #1659654 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
High
Unassigned
Yakkety
Fix Released
High
Stefan Bader

Bug Description

klibc is failing to build on arm64 in yakkety because of a change in unistd.h in linux-libc-dev somewhere between 4.4.0-9136.55 and 4.8.0-36.38:

  gcc -Wp,-MD,usr/klibc/syscalls/.SYSCALLS.i.d -nostdinc -iwithprefix include -I/<<PKGBUILDDIR>>/usr/include/arch/arm64 -Iusr/include/arch/arm64 -I/<<PKGBUILDDIR>>/usr/include/bits64 -Iusr/include/bits64 -I/<<PKGBUILDDIR>>/usr/klibc/../include -Iusr/klibc/../include -I/<<PKGBUILDDIR>>/usr/include -Iusr/include -I/<<PKGBUILDDIR>>/linux/include -Ilinux/include -I/<<PKGBUILDDIR>>/linux/arch/arm64/include -Ilinux/arch/arm64/include -D__KLIBC__=2 -D__KLIBC_MINOR__=0 -D_BITSIZE=64 -fno-stack-protector -fwrapv -fno-exceptions -mgeneral-regs-only -g -Os -march=armv8-a -mtune=generic -W -Wall -Wno-sign-compare -Wno-unused-parameter -I/<<PKGBUILDDIR>>/usr/klibc/syscalls -D__ASSEMBLY__ -ansi -x c -E -o usr/klibc/
syscalls/SYSCALLS.i usr/klibc/SYSCALLS.def
In file included from /<<PKGBUILDDIR>>/linux/include/asm/unistd.h:19:0,
                 from usr/klibc/SYSCALLS.def:13:
/<<PKGBUILDDIR>>/linux/include/asm-generic/unistd.h:734:1: error: C++ style comments are not allowed in ISO C90
 //__SYSCALL(__NR_pkey_get, sys_pkey_get)
 ^
/<<PKGBUILDDIR>>/linux/include/asm-generic/unistd.h:734:1: error: (this will be reported only once per input file)

https://launchpad.net/ubuntu/+source/klibc/2.0.4-8ubuntu3.1/+build/11926893

We should reasonably expect the headers in linux-libc-dev to maximally-conformant C headers.

Steve Langasek (vorlon)
Changed in linux (Ubuntu):
importance: Undecided → High
tags: added: kernel-da-key
Revision history for this message
Brad Figg (brad-figg) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1659654

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Stefan Bader (smb) wrote :

This looks to be introduced by a60f7b69d92c0142c80a30d669a76b617b7f6879 in v4.9-rc1 and fixed up by 71757904efadefdf5505712f675218ce59483c5d in v4.9-rc2. The former was backported into Yakkety to resolve bug #1591804.
Will submit the latter for SRU into Yakkety.

Changed in linux (Ubuntu Yakkety):
assignee: nobody → Stefan Bader (smb)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Stefan Bader (smb) wrote :

Zesty is not affected as the fixup was in v4.9-rc2.

Changed in linux (Ubuntu):
status: Confirmed → Fix Released
Changed in linux (Ubuntu Yakkety):
status: In Progress → Fix Committed
Revision history for this message
Thadeu Lima de Souza Cascardo (cascardo) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-yakkety' to 'verification-done-yakkety'. If the problem still exists, change the tag 'verification-needed-yakkety' to 'verification-failed-yakkety'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-yakkety
Revision history for this message
Steve Langasek (vorlon) wrote :

klibc has now successfully built on arm64 in yakkety.

tags: added: verification-done
removed: verification-needed-yakkety
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (20.4 KiB)

This bug was fixed in the package linux - 4.8.0-38.41

---------------
linux (4.8.0-38.41) yakkety; urgency=low

  [ Thadeu Lima de Souza Cascardo ]

  * Release Tracking Bug
    - LP: #1661232

  * Backport Dirty COW patch to prevent wineserver freeze (LP: #1658270)
    - SAUCE: mm: Respect FOLL_FORCE/FOLL_COW for thp

  * Kdump through NMI SMP and single core not working on Ubuntu16.10
    (LP: #1630924)
    - x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic
    - SAUCE: hv: don't reset hv_context.tsc_page on crash

  * Call trace when testing fstat stressor on ppc64el with virtual keyboard and
    mouse present (LP: #1652132)
    - HID: usbhid: Quirk a AMI virtual mouse and keyboard with ALWAYS_POLL

  * regression in linux-libc-dev in yakkety: C++ style comments are not allowed
    in ISO C90 (LP: #1659654)
    - generic syscalls: kill cruft from removed pkey syscalls

  * [16.04.2] POWER9 patches on top of 4.8 (LP: #1650263)
    - powerpc/book3s: Add a cpu table entry for different POWER9 revs
    - powerpc/mm/radix: Use different RTS encoding for different POWER9 revs
    - powerpc/mm/radix: Use different pte update sequence for different POWER9
      revs
    - powerpc/mm: Update the HID bit when switching from radix to hash
    - powerpc/64/kexec: NULL check "clear_all" in kexec_sequence
    - powerpc/64/kexec: Fix MMU cleanup on radix
    - powerpc/mm: Add radix flush all with IS=3
    - powerpc/64/kexec: Copy image with MMU off when possible
    - powerpc/64: Simplify adaptation to new ISA v3.00 HPTE format
    - powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1
    - powerpc/mm: Fix missing update of HID register on secondary CPUs
    - powerpc/64: Add some more SPRs and SPR bits for POWER9
    - powerpc/64: Provide functions for accessing POWER9 partition table
    - powerpc/powernv: Define real-mode versions of OPAL XICS accessors
    - powerpc/64: Define new ISA v3.00 logical PVR value and PCR register value
    - mm: update mmu_gather range correctly
    - mm/hugetlb: add tlb_remove_hugetlb_entry for handling hugetlb pages
    - mm: add tlb_remove_check_page_size_change to track page size change
    - powerpc: Revert Load Monitor Register Support
    - powerpc/mm: Correct process and partition table max size
    - powernv: Clear SPRN_PSSCR when a POWER9 CPU comes online
    - powerpc/mm/radix: Setup AMOR in HV mode to allow key 0
    - powerpc/mm: Detect instruction fetch denied and report
    - powerpc/mm/radix: Prevent kernel execution of user space
    - powerpc/mm: Rename hugetlb-radix.h to hugetlb.h
    - powerpc/mm/hugetlb: Handle hugepage size supported by hash config
    - powerpc/mm: Introduce _PAGE_LARGE software pte bits
    - powerpc/mm: Add radix__tlb_flush_pte_p9_dd1()
    - powerpc/mm: update radix__ptep_set_access_flag to not do full mm tlb flush
    - powerpc/mm: update radix__pte_update to not do full mm tlb flush
    - powerpc/mm: Batch tlb flush when invalidating pte entries
    - powerpc/sparse: Make a bunch of things static
    - powerpc/perf: factor out the event format field
    - powerpc/perf: update attribute_group data structure
    - powerpc/perf: power9 raw event format en...

Changed in linux (Ubuntu Yakkety):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.