Unit test 'test_to_dict_works_w_missing_manila_context_attributes' fails

[Chuck Short]

======================================================================
FAIL: manila.tests.test_context.ContextTestCase.test_to_dict_works_w_missing_manila_context_attributes
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  stderr
  stdout

pythonlogging:'': {{{
INFO [manila.coordination] Coordination back end started successfully.
    INFO [manila.coordination] Stopped Coordinator (Agent ID: 46e54893-27fb-49c9-8070-13aff0398f9b, prefix: manila-)
}}}

Traceback (most recent call last):
  File "manila/tests/test_context.py", line 81, in test_to_dict_works_w_missing_manila_context_attributes
    res = ctxt.to_dict()
  File "manila/context.py", line 109, in to_dict
    values = super(RequestContext, self).to_dict()
  File "/usr/lib/python2.7/dist-packages/oslo_context/context.py", line 308, in to_dict
    user=self.user_id or '-',
  File "/usr/lib/python2.7/dist-packages/oslo_context/context.py", line 153, in getter
    return getattr(self, target)
AttributeError: 'RequestContext' object has no attribute '_user_id'

[Valeriy Ponomaryov (vponomaryov)]

Cannot reproduce. Test just works.

[Valeriy Ponomaryov (vponomaryov)]

Started failing in CI:

http://logs.openstack.org/14/425814/2/check/gate-manila-python27-db-ubuntu-xenial/db07fe8/testr_results.html.gz

http://logs.openstack.org/14/425814/2/check/gate-manila-python35-db/3bb0bb3/testr_results.html.gz

[Valeriy Ponomaryov (vponomaryov)]

Looks like release of oslo.context==2.12.0 is the cause:

https://review.openstack.org/#/c/421934/
https://github.com/openstack/requirements/commit/75c9ce45

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/426492

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426492
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=412af6c683aedef9f96a35bd01d2161660ce97ca
Submitter: Jenkins
Branch: master

commit 412af6c683aedef9f96a35bd01d2161660ce97ca
Author: vponomaryov <email address hidden>
Date: Sat Jan 28 12:02:24 2017 +0200

    Remove unit test that is not relevant anymore

    Test 'test_to_dict_works_w_missing_manila_context_attributes',
    located in 'manila/tests/test_context.py' module fails with latest
    release of oslo.context lib which is 2.12.0

    Remove this test as irrelevant and unblock CI doing it.

    Change-Id: I2e26b27f4cc17385e5d6897a9d2006b979ea3107
    Close-Bug: #1659371