Duplicate resources in puppet/post.yaml

[Steven Hardy]

There is a mistake in puppet/post.j2.yaml which means we render all the deploy steps in a nested loop for all roles, which makes the rendered file really large (over 3000 lines).

This works because yaml parsing ignores the duplicate resource definitions, but this is a waste of space in swift.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/424896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424896
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d33422d635590ac02e7fb201447ed4a2c801cf35
Submitter: Jenkins
Branch: master

commit d33422d635590ac02e7fb201447ed4a2c801cf35
Author: Steven Hardy <email address hidden>
Date: Tue Jan 24 23:17:50 2017 +0000

    Remove spurious for loop from post deploy j2

    This nested for loop is wrong as it generates all steps for all
    roles twice. This works because yaml parsing ignores the duplicate
    resources, but it's a big waste of space in swift (this fix reduces
    the rendered file size by over 2000 lines with the default roles!)

    Change-Id: Ifaf860020839390147c92848d52b1a59e355dc50
    Closes-Bug: #1659139

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.