[regression] Mir cross-compile to vivid/armhf FTBFS with: mock_input_device_hub.h:33:18: error: ‘add_observer’ is not a type

[Daniel van Vugt]

xenial$ ./cross-compile-chroot.sh -d vivid -a armhf

In file included from /home/dan/bzr/mir/fixy/tests/unit-tests/input/test_config_changer.cpp:29:0:
/home/dan/bzr/mir/fixy/include/test/mir/test/doubles/mock_input_device_hub.h:33:18: error: ‘add_observer’ is not a type
     MOCK_METHOD1(add_observer, void(std::shared_ptr<input::InputDeviceObserver> const&));
                  ^
/home/dan/bzr/mir/fixy/include/test/mir/test/doubles/mock_input_device_hub.h:33:88: error: ISO C++ forbids declaration of ‘MOCK_METHOD1’ with no type [-fpermissive]
     MOCK_METHOD1(add_observer, void(std::shared_ptr<input::InputDeviceObserver> const&));
                                                                                        ^
/home/dan/bzr/mir/fixy/include/test/mir/test/doubles/mock_input_device_hub.h:34:18: error: ‘remove_observer’ is not a type
     MOCK_METHOD1(remove_observer, void(std::weak_ptr<input::InputDeviceObserver> const&));
                  ^
......

[Daniel van Vugt (vanvugt)]

Predictably the regression happened recently, after we had removed vivid from CI...

------------------------------------------------------------
revno: 3962 [merge]
author: Andreas Pokorny <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2017-01-19 09:38:52 +0000
message:
  mirserver: Add InputConfigurationChanger and a default implementation

  This adds mir::input::ConfigChanger which will keep track of per session input device configurations. Similar but simpler than MediatingDisplayChanger. This does not activate the configuration tracking yet.

  Approved by mir-ci-bot, Kevin DuBois, Cemil Azizoglu.
------------------------------------------------------------

[Mir CI Bot (mir-ci-bot)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package mir - 0.26.0+17.04.20170126.3-0ubuntu1

---------------
mir (0.26.0+17.04.20170126.3-0ubuntu1) zesty; urgency=medium

  [ Daniel van Vugt ]
  * New upstream release 0.26.0 (https://launchpad.net/mir/+milestone/0.26.0)
    - ABI summary:
      . mirclient ABI unchanged at 9
      . mirserver ABI bumped to 43
      . mircommon ABI unchanged at 7
      . mirplatform ABI unchanged at 14
      . mirprotobuf ABI unchanged at 3
      . mirplatformgraphics ABI unchanged at 11
      . mirclientplatform ABI unchanged at 5
      . mirinputplatform ABI unchanged at 6
      . mircore ABI unchanged at 1
    - Enhancements:
      . New/improved toolkit APIs: MirInputConfig and related functions,
        MirWindow and related functions, DisplayConfig and related functions,
        MirScreencastSpec and related functions,
      . Support for configuring input configuration
      . Introduce toolkit extension mechanism for platform specific APIs.
      . Toolkit extensions for: mesa_drm_auth, set_gbm_device and
        window_coordinate_translation
      . Screencasting to a specific MirBuffer.
      . Add DisplayConfigurationController::base_configuration() so downstreams
        can get the base configuration. (Weirdly they can already set it.).
      . x11 platform: allow adjustable scale parameter.
      . Added EDID support: client API, server logging and in mirout.
      . mirout: Add newer attributes only available in the new display
        config API: scaling factor, subpixel arrangement and form factor.
      . mirout: Log the orientation and logical size of each output too.
      . Replace the mir::Server-overridable Reports with Observers.
      . Add xkbcommon to mirclient.pc Requires.private.
      . Deprecate legacy toolkit APIs that will be removed in Mir 1.0
      . Introduced 'client-side vsync', which dramatically reduces latency
        from the client to the screen (particularly for nested servers like
        Unity8).
    - Bugs fixed:
      . [performance] Restore support for better-than-triple buffering by
        default. (LP: #1240909)
      . Frame rate is artificially low on Diamondville Intel Atom systems due
        to aggressive power management (LP: #1388490)
      . [testsfail] failure in CI in
        AndroidInputReceiverSetup.slow_raw_input_doesnt_cause_frameskipping
        (LP: #1394369)
      . [trusted prompt sessions] Can't open two prompt sessions at the same
        time (LP: #1494197)
      . Changing scale, formFactor or DPI in display configuration causes
        renderer teardown/recreate unnecessarily (LP: #1556142)
      . [testsfail] ApplicationNotRespondingDetection.failure_to_pong_is_
        noticed (LP: #1570327)
      . CI failure in TestClientInput.receives_one_touch_event_per_frame
        (LP: #1570698)
      . Mir-on-X mouse input is jerky/stuttery compared to Mir-on-KMS
        (LP: #1576600)
      . [regression] Two fingers in mir_proving_server now resizes/moves app
        windows (two finger apps unusable) (LP: #1586311)
      . Pointer/cursor input lag in unity8 session (LP: #1591328)
      . PointerConfinement.test_we_update_our_confined_region_on_a_resize
      ...