Mysql ocf race introduce

[Nikita Koshikov]

Hello,

fix to this bug introduce sleep, that always executed on primary-contoller:
https://review.openstack.org/#/c/356123/

$ if [ "$GTID"="0" ]; then echo 'BINGO'; fi
BINGO
$ if [ "$GTID"="0" ]; then echo 'BINGO'; fi
BINGO
$ if [ "$GTID"=="0" ]; then echo 'BINGO'; fi
BINGO
$ if [[ "$GTID"=="0" ]]; then echo 'BINGO'; fi
BINGO

Because of that new function + sleep, mysql split brain condition became really easy thing to obtain. Run while true; update database; sleep 0.1; done and in next 5 minutes you'll have split-brain. The fix is trivial:
root@node-6:/usr/lib/ocf/resource.d/fuel# diff -u mysql-wss mysql-wss.fixed
--- mysql-wss 2017-01-20 16:53:24.764587866 +0000
+++ mysql-wss.fixed 2017-01-20 16:53:12.212299614 +0000
@@ -343,7 +343,7 @@

     GTID=$(get_node_gtid $NODE)

- if [ "$GTID"="0" ]; then
+ if [ "$GTID" = "0" ]; then
         sleep $[ ( $RANDOM % 10 ) + 1]
         GTID=$(get_node_gtid $NODE)
     fi

[Oleksiy Molchanov (omolchanov)]

https://review.openstack.org/#/c/423415/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424498

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/424565

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424498
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=70239cadfef134bdfc45ada59c7c225f6cbfcb5d
Submitter: Jenkins
Branch: stable/newton

commit 70239cadfef134bdfc45ada59c7c225f6cbfcb5d
Author: Sergii Golovatiuk <email address hidden>
Date: Fri Jan 20 20:09:13 2017 +0100

    Fix mysql OCF race

    - Fix bug
    - Fix issues found in bashate

    Closes-Bug: #1658144

    Change-Id: I93e9ab269d3ad4a285154fafcac6426ef36f6b52

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424565
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=111ed81108c4ab68d2d5e24400a663f94335397d
Submitter: Jenkins
Branch: stable/mitaka

commit 111ed81108c4ab68d2d5e24400a663f94335397d
Author: Sergii Golovatiuk <email address hidden>
Date: Fri Jan 20 20:09:13 2017 +0100

    Fix mysql OCF race

    - Fix bug
    - Fix issues found in bashate

    Closes-Bug: #1658144

    Change-Id: I93e9ab269d3ad4a285154fafcac6426ef36f6b52

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/423415
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=2326ef963a51379d54d402ab19b9dc98985b1424
Submitter: Jenkins
Branch: master

commit 2326ef963a51379d54d402ab19b9dc98985b1424
Author: Sergii Golovatiuk <email address hidden>
Date: Fri Jan 20 20:09:13 2017 +0100

    Fix mysql OCF race

    - Fix bug
    - Fix issues found in bashate

    Closes-Bug: #1658144

    Change-Id: I93e9ab269d3ad4a285154fafcac6426ef36f6b52

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.

[Ekaterina Shutova (eshutova)]

Verified on 9.2 mu1 updates.
No 'split-brain' observed in logs during writing to db during ~5min.