Parameters from environment ignored when uploading a HEAT template

[Radomir Dopieralski]

When creating a new stack, we can specify a heat template file and an environment file. However, the parameter values specified in the environment file are completely ignored in the second step of the wizard, where we still need to fill all the parameters manually. Even though the environment file is getting passed to heat and could be used to get those values, the fields in the second step of the wizard are all required, so it's impossible to skip them.

[Radomir Dopieralski (deshipu)]

I think that we should not include in the second step the parameters that are already covered in the environment file -- or perhaps include them, but pre-filled with the environment's values.

[Radomir Dopieralski (deshipu)]

I found the problem. The values are actually filled by the API call to Heat to validate the template. However, the name of the key that stores the default value for the parameter changed from "Default" to "DefaultValue".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/432259

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/432259
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2e7b53ea6b6f448846e27892dfbb2e1974b5b3a3
Submitter: Jenkins
Branch: stable/newton

commit 2e7b53ea6b6f448846e27892dfbb2e1974b5b3a3
Author: Radomir Dopieralski <email address hidden>
Date: Thu Feb 9 11:23:55 2017 +0100

    Use "Default", "Value" and "DefaultValue" for Heat parameters

    It seems there has been changes in the Heat API, and it no longer
    returns the default value for a parameter in the "Default" key, it
    has been instead renamed to "DefaultValue" and later to "Value".
    This patch makes it use all those key names, whichever exists.

    Clases-bug: 1658111
    Change-Id: Ia86d8d79fcd48974ffe3fecf21a7153bf2ba6a9a
    (cherry picked from commit 39e2bb784c1c0a6f3d87910371aa959cf835d461)

[Richard Jones (r1chardj0n3s)]

Due to a typo in the commit message this bug wasn't automatically updated.