Error with Recalls: Can't locate object method "workstation" via package "action::circulation" at CDBI.pm line 181

[Jason Etheridge]

collab/phasefx/cdbi_fix @ working

commit d6b672b419796a681433cc082cdf6916bb4cb6f0
Author: Jason Etheridge <email address hidden>
Date: Tue Jan 17 16:39:58 2017 -0500

    Fix Can't locate object method "workstation" error

    When trying to utilize the Recall functionality, Evergreen would fail to update
    targeted circulations (truncate the due date, etc.) In the logs, we would have
    an error like this:

    [] open-ils.storage [ERR ::action.pm:1597:] Processing of hold failed:
    Can't locate object method "workstation" via package "action::circulation" at
    /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/CDBI.pm line 181.

    We first tried adding the workstation column to Storage/CDBI/action.pm, but a
    similar message would then appear instead: Can't locate object method
    "checkin_workstation"

    This sidesteps the problem entirely.

    Thanks to Mike for the solution!

    Signed-off-by: Jason Etheridge <email address hidden>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm b/Open-ILS/src/perlmods/lib/O
index d8391b8..d164251 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/CDBI.pm
@@ -178,7 +178,7 @@ sub to_fieldmapper {

     if (ref($obj)) {
         for my $field ( $fm->real_fields ) {
- $fm->$field( ''.$obj->$field ) if defined $obj->$field;
+ $fm->$field( ''.$obj->$field ) if $obj->find_column($field) && defined $obj->$field;
         }
     }

[Jason Etheridge (phasefx)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=refs/heads/collab/phasefx/cdbi_fix

[Erica Rohlfs (erohlfs)]

Confirmed in EG 2.9 and 2.11.

[Mike Rylander (mrylander)]

Merged for great justice. Thanks, Jason!