[9.1][updates] 9.1 env with plugins cannot be updated to 9.2 due to dir structure change

[Ruslan Khozinov]

Env description:

Fuel9.1 with
 - controller
 - compute+cinder
 - murano
 - kibana+grafana

snapshot id: 767
mos_release: "http://mirror.fuel-infra.org/mos-repos/centos/mos9.0-centos7/9.2-updates/x86_64/Packages/mos-release-9.2-1.el7.x86_64.rpm"
ansible: ansible.noarch 2.1.1.0-1.el7~mos2 @mos92-updates

Steps to reproduce:

1. Deploy 9.0 with stacklight + murano plugins
2. Update the fuel up to 9.1
3. Update an env with packages from the mos-updates repo
4. Follow the guide for the mos_mu util https://github.com/rkhozinov/mos_mu/blob/9.2/doc/usage_9x.md

ansible-playbook playbooks/mos9_prepare_fuel.yml
ansible-playbook playbooks/update_fuel.yml -e '{"rebuild_bootstrap":false}'

Actual result:

2017-01-17 15:08:51,759 p=17655 u=root | fatal: [nailgun.test.domain.local]: FAILED! => {"changed": true, "cmd": ["/etc/puppet/modules/fuel/examples/deploy.sh"], "delta": "0:03:28.662916

Additional information:

mos_mu from git

02f5cbbb8ce9c7a33b956630319287b06afd7a65 Merge branch 'master' into 9.2
69ee9f7562af9ae0681d0a76f29281a3bc5512e8 Exclude 'too many PGs per OSD' warn from CEPH health_check
6ddf7666712b2208f3f85fadb7385c607c8380c2 Return back adding GPG key for mos9.2 repos
9bb3d38dcadcd577f070741cc363e8c09ca2fd44 Fix one more typo
05b571bb4db942ef014147278c822901f29d0d66 Fix typos in add_repo_to_env
83343747bcd2e7f0aadfe8e1f06d092b896e9011 Fix bug #1652274

[Ruslan Khozinov (rkhozinov)]

 "stderr": "Warning: Scope(Class[Rabbitmq]): $ssl_stomp_port requires that $ssl => true and will be ignored\nWarning: Scope(Class[Keystone]): Keystone under Eventlet has been deprecated during the Kilo cycle. Support for deploying under eventlet will be dropped as of the M-release of OpenStack.\nWarning: Puppet::Type::Keystone_tenant::ProviderOpenstack: Support for a resource without the domain set is deprecated in Liberty cycle. It will be dropped in the M-cycle. Currently using 'Default' as default domain name while the default domain id is '26985a9d7e3049e380cc838fc812bbfa'.\nError: Could not remove existing file\nError: /Stage[main]/Fuel::Nailgun::Server/File[/etc/fuel/plugins]/ensure: change from directory to link failed: Could not remove existing file",

[Ruslan Khozinov (rkhozinov)]

/etc/yum.repos.d/mos92-updates.repo
[mos92-updates]
name=mos92-updates
baseurl=http://mirror.seed-us1.fuel-infra.org/mos-repos/centos/mos9.0-centos7/snapshots/proposed-2017-01-13-184421/x86_64/
        http://mirror.seed-cz1.fuel-infra.org/mos-repos/centos/mos9.0-centos7/snapshots/proposed-2017-01-13-184421/x86_64/
enabled=1
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-mos9.0
gpgcheck=1

[Anton Chevychalov (achevychalov)]

There is a incompatibility between 9.1 and 9.2 that force us to rebuild all plugins.

Root cause is changes in directories structure that reflect in https://review.openstack.org/#/c/411904/

While we had following structure previously:

/etc/fuel/plugins - dir
/var/www/nailgun/plugins/ - dir

/etc/fuel/plugins/<plugin_name> is symbolic link to
/var/www/nailgun/plugins/<plugin_name>/deployment_scripts

No we have symbolic link
/etc/fuel/plugins -> /var/www/nailgun/plugins/

So there is no way have "old" and "new" plugins work in the same time.

[Alexey Shtokolov (ashtokolov)]

https://review.openstack.org/#/c/421841/

[Ruslan Khozinov (rkhozinov)]

I've applied that fix manually (https://review.openstack.org/#/c/421841/1/deployment/puppet/fuel/manifests/nailgun/server.pp)
and the fuel_udate task has been finished successfully.