Detailed bug description:
When I start to deploy env on barametal lab it is impossible because of Error
'NoneType' object has no attribute 'update'
Steps to reproduce:
1) Create env
2) Start deploy
Expected results:
deployment is successful
Actual result:
'NoneType' object has no attribute 'update' at the beginning
Description of the environment:
1 controller
1 compute with pinning
1 compute with hp
2 compute with sr-iov
snapshot #767
Full trace:
ERROR [7ff76ccf0880] (manager) Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nailgun/task/manager.py", line 61, in _call_silently
to_return = method(task, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/nailgun/task/task.py", line 258, in message
dry_run=dry_run, **kwargs
File "/usr/lib/python2.7/site-packages/nailgun/task/task.py", line 136, in call_deployment_method
args = getattr(cls, method)(transaction, **kwargs)
File "/usr/lib/python2.7/site-packages/nailgun/task/task.py", line 531, in task_deploy
transaction.cluster, nodes
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 1008, in serialize_for_lcm
ignore_customized, skip_extensions
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 990, in _invoke_serializer
ignore_customized=ignore_customized, skip_extensions=skip_extensions
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 128, in serialize
self.serialize_generated(origin_nodes, skip_extensions)
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 148, in serialize_generated
serialized_nodes = self.serialize_nodes(nodes)
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 840, in serialize_nodes
self.serialize_node(node, roles)
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 854, in serialize_node
serialized_node = base.serialize_node(node, roles[0])
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 677, in serialize_node
self.serialize_node_attributes(node, serialized_node)
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 681, in serialize_node_attributes
self.generate_cpu_pinning(node, serialized_node)
File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 701, in generate_cpu_pinning
serialized_node.get('dpdk').update(objects.Node.get_attributes(node)
AttributeError: 'NoneType' object has no attribute 'update'
It is a regression issue (so code worked fine the week before) and it is Critical issue because we can't deploy environment (with any configuration) of the hardware lab.
Steps To Reproduce are simple:
1. Deploy master node with Fuel 9.2
2. Add bare-metal nodes for controller and computes
3. Press "deploy environment" button
Observed Result:
We got an exception from Nailgun python code about the None parameter, because of the bug in the code.
Note: I know how to fix it, the fix is trivial and shouldn't affect other features.
I'm going to create pull request.