Soldiers in stopped trainings site get exchanged

[Notabilis]

Sometimes, soldiers in a stopped (barbarian) training camp are endlessly replaced with soldiers in the warehouse. I have no real idea how to trigger this bug(?), though. In my test game I trained the soldiers in evasion and build a paused training camp equipped with helmets.

After some time* the camp starts to replace its soldiers. The trainer seems to prefer kicking out partially trained soldiers, if none are present untrained soldiers are kicked. This can be observed in the attached save game.

Observed in bzr8237[trunk].

For reference: Tino noticed this effect in a test game of the casern branch and reported it here:
https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763/comments/818541

* To be exact, it happened after I saved the game. But that is most likely unrelated, since saving wasn't required to trigger the effect in the casern branch.

[Teppo Mäenpää (kxq)]

I did not think of stopped buildings while implementing the soldier exchange -> genuine bug.

[Teppo Mäenpää (kxq)]

I take that back. The soldier exchange happens at program_end(), which should not be repeatedly called when the site is stopped.

Does the training site actually train soliders when this thing happens?

[Notabilis (notabilis27)]

No, no training is happening, but food and helmets required for training are present.

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/1663