Unable disable iptables service on system have iptables

Bug #1656148 reported by leehom
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
In Progress
Undecided
leehom

Bug Description

In order to prevent diskimage-builder from executing fail
when base image uses systemd but the iptables service is not
present, we merged below patch.

https://review.openstack.org/gitweb?p=openstack/diskimage-builder.git;a=commitdiff;h=dd7648277fa45f102c4dd30bde90bd44ecb8a553

In above patch we use "systemctl --no-pager list-unit-files iptables =~ 'enabled'"
to check if iptables service present and enabled.

But with "systemctl --no-pager list-unit-files iptables" we can not get the STATE of
iptables service.
The output of above command is

# systemctl --no-pager list-unit-files iptables
UNIT FILE STATE

0 unit files listed.

In order to get the proper state we should use
# systemctl --no-pager list-unit-files iptables*
or
# systemctl --no-pager list-unit-files iptables.service
instead.

leehom (feli5)
Changed in diskimage-builder:
assignee: nobody → leehom (feli5)
summary: - Unable to disable iptables service with system have iptables
+ Unable disable iptables service on system have iptables
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/419703

Changed in diskimage-builder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/423720

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/423722

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on diskimage-builder (master)

Change abandoned by Leehom Li (<email address hidden>) on branch: master
Review: https://review.openstack.org/423720

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Leehom Li (<email address hidden>) on branch: master
Review: https://review.openstack.org/423722

Changed in diskimage-builder:
assignee: leehom (feli5) → Ben Nemec (bnemec)
Ben Nemec (bnemec)
Changed in diskimage-builder:
assignee: Ben Nemec (bnemec) → leehom (feli5)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.