[puppet4] fuel-pkgs task fails

[Nikita Karpin]

During deployment of the environment fuel-pkgs task fails with error:

E: No priority (or zero) specified for pin
ERR Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold -o APT::Get::AllowUnauthenticated=1 install fuel-ha-utils' returned 100: Reading package lists..

Output from one of the controllers:

root@node-3:~# ls /etc/apt/preferences.d/
Auxiliary.pref mos-holdback.pref mos.pref mos-puppet4.pref mos-security.pref mos-updates.pref ubuntu.pref ubuntu-security.pref ubuntu-updates.pref
root@node-3:~# cat /etc/apt/preferences.d/ubuntu.pref
# This file is managed by Puppet. DO NOT EDIT.
Explanation: osnailyfacter: ubuntu
Package: *
Pin: release a=xenial, n=xenial, o=Ubuntu, l=Ubuntu
Pin-Priority: 0

As we can see ubuntu repositories pins were created with 0 priorities. It's related to that fact that Puppet 4 functions parse null value from yaml backend as ruby :undef value, and it is treated as true here - https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/lib/puppet/parser/functions/generate_apt_pins.rb#L22

Environment:
Fuel custom ISO - https://custom-ci.infra.mirantis.net/job/11.0.custom.iso/22/
Puppet version - 4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/419465

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/419465
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4e37655b4ea33e52ef6fb37e3c9671a9d101b858
Submitter: Jenkins
Branch: master

commit 4e37655b4ea33e52ef6fb37e3c9671a9d101b858
Author: Mykyta Karpin <email address hidden>
Date: Thu Jan 12 15:40:54 2017 +0200

    Fix apt pins generation

    In Puppet 4 null value in
    yaml backend is treated as Undef symbol. This
    behaviour causes generate_apt_pins() function
    to create pins with zero priority.

    Closes-Bug: #1655961

    Change-Id: I1d2bf737e88bba37e08e19c0be1f86c74f1dbd5c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/430928

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/430929

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/430928
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9741cc4ef434fd677e37b99a0aace10515b04b77
Submitter: Jenkins
Branch: stable/newton

commit 9741cc4ef434fd677e37b99a0aace10515b04b77
Author: Mykyta Karpin <email address hidden>
Date: Thu Jan 12 15:40:54 2017 +0200

    Fix apt pins generation

    In Puppet 4 null value in
    yaml backend is treated as Undef symbol. This
    behaviour causes generate_apt_pins() function
    to create pins with zero priority.

    Closes-Bug: #1655961

    Change-Id: I1d2bf737e88bba37e08e19c0be1f86c74f1dbd5c
    (cherry picked from commit 4e37655b4ea33e52ef6fb37e3c9671a9d101b858)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/430929