disk utils creates an ext2 configdrive, only compatible with linux

Bug #1655389 reported by Jay Faulkner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Unassigned
ironic-lib
Fix Released
Low
Jay Faulkner
ironic-python-agent
Fix Released
Low
Unassigned

Bug Description

ironic-lib, when it creates a configdrive, is creating it as ext2 (https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L759). This is bad as the standard (http://cloudinit.readthedocs.io/en/latest/topics/datasources/configdrive.html#version-2) requires ISO or VFAT format.

We later, in most cases, have a nova configdrive to image over this, making the bug significantly less impactful.

Changed in ironic:
importance: Undecided → High
Changed in ironic-python-agent:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/418458

Revision history for this message
Jay Faulkner (jason-oldos) wrote :

Because this created partition is imaged with the configdrive image created by nova, this bug is less severe than it seems at first glance. We should still use a compatible filesystem for consistency with what nova will put down, but it's not a major bug, and would not impact windows users.

description: updated
Changed in ironic:
importance: High → Low
Changed in ironic-python-agent:
importance: High → Low
Changed in ironic-lib:
importance: High → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-lib (master)

Reviewed: https://review.openstack.org/418458
Committed: https://git.openstack.org/cgit/openstack/ironic-lib/commit/?id=2f0ea84488d2944d2e0f22b6b6d29508d061b8f8
Submitter: Jenkins
Branch: master

commit 2f0ea84488d2944d2e0f22b6b6d29508d061b8f8
Author: Jay Faulkner <email address hidden>
Date: Tue Jan 10 08:07:49 2017 -0800

    Create configdrive partitions as vfat

    This fixes a bug where ironic-lib would create configdrive partitions as
    ext2, which is incompatible with any OS but Linux and goes against the
    configdrive standard as written in cloud-init docs.

    Change-Id: Ib4ad8e0b4d6dbef9d441d9ae13fd82f8f51957e6
    Closes-bug: #1655389

Changed in ironic-lib:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic-lib 2.5.0

This issue was fixed in the openstack/ironic-lib 2.5.0 release.

Revision history for this message
Dmitry Tantsur (divius) wrote :

I guess this issue was fixed by the ironic-lib change

Changed in ironic:
status: New → Fix Released
Changed in ironic-python-agent:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.