Low performance when instances are using not available flavour

[Mateusz Kowalski]

When user has a lot of machines using flavour which is not available anymore, performance of instance list panel is very bad. The reason is the redundant API call in instances/views.py for each machine like this.

Horizon first grabs a list of all available flavours and then iterates through all machines. If for a particular one flavour is not on the cached list, it sends an API request to nova. I believe it's redundant, as if the flavour was not grabbed in the first call, it won't appear in any of the following.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418313

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418314

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mateusz Kowalski (<email address hidden>) on branch: master
Review: https://review.openstack.org/418313
Reason: Duplicate of 418313

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/418409

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mateusz Kowalski (<email address hidden>) on branch: master
Review: https://review.openstack.org/418314
Reason: Duplicate of 418409

[Mateusz Kowalski (makowals)]

The running fix is https://review.openstack.org/#/c/418409/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418409
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=46c4c3d4f993e793d32de65f0cc99ad2b00a2cf1
Submitter: Jenkins
Branch: master

commit 46c4c3d4f993e793d32de65f0cc99ad2b00a2cf1
Author: Mateusz Kowalski <email address hidden>
Date: Tue Jan 10 10:10:08 2017 +0100

    If the flavor_id not in full_flavors, don't make a new API request

    Flavors are cached from api.nova.flavor_list(), therefore if we have
    machine for which flavor is not in the obtained list, it means the
    machine has been created using flavor which is not available anymore.
    Additional API calls are just decreasing the performance.

    Change-Id: I190ae0bd70fc19a9d2d402a808f465c23c842fa7
    Closes-bug: #1655300

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.