race in router delete with ha port creation

[Kevin Benton]

http://logs.openstack.org/54/417854/1/check/gate-neutron-dsvm-fullstack-ubuntu-xenial/a0330f8/logs/dsvm-fullstack-logs/TestHAL3Agent.test_ha_router/neutron-server--2017-01-10--06-36-00-438766.txt.gz#_2017-01-10_06_36_13_353

[Jakub Libosvar (libosvar)]

Proposed fix: https://review.openstack.org/#/c/418281/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418281
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4c636bd1e62394025cc118f19c7b0fa2d65fe444
Submitter: Jenkins
Branch: master

commit 4c636bd1e62394025cc118f19c7b0fa2d65fe444
Author: Kevin Benton <email address hidden>
Date: Tue Jan 10 02:28:46 2017 -0700

    Retry on routerport delete race

    After deleting the router interfaces, another concurrent
    process (e.g. HA port creation) could happen before the actual
    router is deleted, which would lead to an SQLAlchemy error due
    to the relationship being violated.

    This patch fixes the issue by bumping the router revision before
    deleting the router to check for concurrent interface additions.
    A race will trigger a staledataerror which will be retried by
    the decorator

    Closes-Bug: #1655281
    Change-Id: I465e9a2f9b216991afa26c16271854fb88068006

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0rc1 release candidate.

[Miguel Angel Ajo (mangelajo)]

Non backportable without also pulling revisions too which was introduced in ocata.