plugin role attribute has_primary:true is not recognized

[Illia Polliul]

In our plugin there's a role `contrail-controller` with `has_primary: true`, but in the env with one such node it turned to be non-primary:

root@node-1:~# hiera roles
[”contrail-controller”]

This breaks task execution ordering.

Logs snapshot is downloading, will attach when available.

[Illia Polliul (ipolliul)]

here is a link to log snapshot https://drive.google.com/file/d/0BzdcP1_NuusEeGdlRndNUE82Ylk/view?usp=sharing

only one plugin in the env: contrail
version of the plugin 5.0.0

[Alexander Kislitsky (akislitsky)]

We are checked the problem env and there was wierd data in the DB. In plugins.roles_metadadata there wasn't 'tags' for roles, but this data is added by migration for existed plugins: https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/db/migration/alembic_migrations/versions/fuel_9_2.py#L805. I've improved migration test for this case: https://review.openstack.org/#/c/418473/

For the new plugins 'tags' data added to the plugins.roles_metadata by: https://github.com/openstack/fuel-web/blob/stable/mitaka/nailgun/nailgun/objects/plugin.py#L84

On the problem env we have no 'tags' in the plugins.roles_metadata, but last DB migration is applied accordingly to the data in the alembic_migrations table.

After removing/installing the plugin primary_tags were set correctlly.

It is unable to reproduce the bug without detailed steps to reproduce. Marking the bug as Incomplete.

[Alexander Kislitsky (akislitsky)]

The reason of inconsistent data in the DB - bug in the plugins synchronisation. When plugin is synced, roles_metadata is just rewritten without tags info.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418982

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418983

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418473
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6b4d6acac1b9358c74a2706e9fdedf81b4c50e61
Submitter: Jenkins
Branch: master

commit 6b4d6acac1b9358c74a2706e9fdedf81b4c50e61
Author: Alexander Kislitsky <email address hidden>
Date: Tue Jan 10 17:59:33 2017 +0300

    Tags info calculation is supported on plugins update

    For instance we made plugins sync operation. In this case
    tags info should be processed on the same way as on plugin
    creation.
    Also test for tags metadata migration improved.

    Change-Id: I937bb581f61034d027b28a8e4fd5b42a35fcd7f6
    Closes-Bug: #1655264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418982
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=3850bba4832916938419f4d499b023ce6e59e1be
Submitter: Jenkins
Branch: stable/mitaka

commit 3850bba4832916938419f4d499b023ce6e59e1be
Author: Alexander Kislitsky <email address hidden>
Date: Wed Jan 11 17:40:58 2017 +0300

    Tags info calculation is supported on plugins update

    For instance we made plugins sync operation. In this case
    tags info should be processed on the same way as on plugin
    creation.
    Also test for tags metadata migration improved.

    Change-Id: I2eebc40af3c3f360e2ef96958a38c7eae0da43d5
    Closes-Bug: #1655264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418983
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=baa107f31873624e98da76a85dd6a60205899050
Submitter: Jenkins
Branch: stable/newton

commit baa107f31873624e98da76a85dd6a60205899050
Author: Alexander Kislitsky <email address hidden>
Date: Tue Jan 10 17:59:33 2017 +0300

    Tags info calculation is supported on plugins update

    For instance we made plugins sync operation. In this case
    tags info should be processed on the same way as on plugin
    creation.
    Also test for tags metadata migration improved.

    Change-Id: I937bb581f61034d027b28a8e4fd5b42a35fcd7f6
    Closes-Bug: #1655264

[Yevgeniy (yshapovalov)]

verified for mos9.2 with contrail plugin 5.0.1

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.