Replace phantomjs with jsdom for unit testing the ui

Bug #1655026 reported by Florian Fuchs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Honza Pokorny

Bug Description

We currently use phantomjs for unit testing the UI. Given that phantoms is not a lightweight dependency and has been involved in a number of failed builds, we might investigate replacing it with jsdom, which is a pure JS implementation of the DOM (and should be sufficient for unit testing).

Tags: ui
Honza Pokorny (hpokorny)
Changed in tripleo:
importance: Wishlist → Medium
assignee: nobody → Honza Pokorny (hpokorny)
milestone: pike-2 → pike-1
Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
assignee: Honza Pokorny (hpokorny) → Jiri Tomasek (jtomasek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/443527

Changed in tripleo:
assignee: Jiri Tomasek (jtomasek) → Honza Pokorny (hpokorny)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/440164
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=06dee4582f002988138a9ff23a2293cf752eb300
Submitter: Jenkins
Branch: master

commit 06dee4582f002988138a9ff23a2293cf752eb300
Author: Jiri Tomasek <email address hidden>
Date: Thu Mar 2 08:19:22 2017 +0100

    Refactor testing to use jest

    The old system, which uses PhantomJS and Karma, prevents us from testing
    i18n-enabled components. Thus, we're refactoring the code to use
    jest/enzyme/jsdom. This should also make tests run faster.

    Depends-On: I407743cbef8109455fa84ef901acee8d177ee2a4
    Implements: blueprint tripleo-ui-replace-phantomjs
    Co-Authored-By: Honza Pokorny <email address hidden>
    Closes-Bug: #1655026
    Change-Id: Id6ad9898922c836bbda1c3c4c3147c137d301245

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/443527
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=fa8a1eeec1c5a80e3d614b4f8d36a9a6e5e07068
Submitter: Jenkins
Branch: master

commit fa8a1eeec1c5a80e3d614b4f8d36a9a6e5e07068
Author: Jiri Tomasek <email address hidden>
Date: Thu Mar 9 10:19:44 2017 +0100

    Re-enable components tests

    Since we have transitioned to using jest, it is now possible to test
    internationalized components

    Partial-Bug: #1655026
    Change-Id: Id83722be0d07e9938b9d3b893518624ba2962764

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 7.0.0

This issue was fixed in the openstack/tripleo-ui 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.