Update of DVR router to be HA fails with 'HAmodeUpdateOfDvrNotSupported'

[Gena]

Though the creation of DVR HA router succeeds, it's impossible to "update" router to be DVR and HA
Trying to update DVR router to be HA you get:
 501-{u'NotImplementedError': {u'message': u'', u'type': u'HAmodeUpdateOfDvrNotSupported', u'detail': u''}}
Neutron server returns request_ids: ['req-d0727fec-3112-4d2b-9f67-d23cf78e4c5f']

[Assaf Muller (amuller)]

Just to rephrase, you're saying that updating a DVR router to DVR+HA fails with the not implemented error?

[John Schwarz (jschwarz)]

@Assaf, yes. This is also the case when updating a HA router to DVR+HA. The migration is disabled in the code.

I'm working on a fix.

[John Schwarz (jschwarz)]

A fix: https://review.openstack.org/#/c/376550

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376550
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=318650ab806f4251974abfa9ffb26cb4edf7d515
Submitter: Jenkins
Branch: master

commit 318650ab806f4251974abfa9ffb26cb4edf7d515
Author: John Schwarz <email address hidden>
Date: Mon Sep 26 17:36:53 2016 +0300

    Allow all migration of routers

    This patch proposes the allowance of changing a router's 'distributed'
    or 'ha' attributes without any restriction as to the previous state of
    these attributes, as long as the router's admin_state_up is False.

    Closes-Bug: #1654991
    Change-Id: Iad4dd77f74ba01876e0091112a1e24a3463993d1

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418276
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2665f968575edef56b3b8b6189f48a89a7a6e646
Submitter: Jenkins
Branch: master

commit 2665f968575edef56b3b8b6189f48a89a7a6e646
Author: Genadi Chereshnya <email address hidden>
Date: Tue Jan 10 11:17:07 2017 +0200

    Check permutations of router migrations

    This patch adds tests to check all possible router migrations, from and
    to: legacy, dvr, ha and dvr+ha.

    The tests are divided into different classes so as to not reach the
    quota (tempest resources are cleaned up as part of the tearDownClass).

    Related-Bug: #1654991
    Depends-On: I4e08a97158dc4538c6f021c049c6e60fb7293459
    Change-Id: I5b9fc4a81a1e6d59102c016e716000e68aaf4e0a