test_sql_upgrade docstring needs update

Bug #1654659 reported by Rodrigo Duarte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Tin Lam

Bug Description

Currently, the docstring at [1] states the usage of the backend_sql.conf file, which isn't used anymore in the tests of the module. Instead, the tests are using oslo.db unit tests base [2]. This doesn't mean the backend_sql.conf file isn't used anywhere else, but that it is not used anymore at test_sql_upgrade.

[1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L14-L32
[2] http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/417647

Changed in keystone:
assignee: nobody → Tin Lam (tl3438)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/417647
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=d42bb2da670022cfdfc00900f8da27421d26af67
Submitter: Jenkins
Branch: master

commit d42bb2da670022cfdfc00900f8da27421d26af67
Author: Tin Lam <email address hidden>
Date: Sat Jan 7 22:46:05 2017 -0600

    Updated docstring for test_sql_upgrade.py

    The docstring at [1] references usage of backend_sql.conf, which is no
    longer used by the tests. The tests are using oslo.db unit tests base.
    This patchset updates the docstring and places a reference to [2].

    [1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_sql_upgrade.py#L14-L32
    [2] http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests

    Change-Id: Ifc3cb8c2a57c83a44408be5771a88f141d6b31e5
    Closes-Bug: #1654659

Changed in keystone:
status: In Progress → Fix Released
Changed in keystone:
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.0.0b3

This issue was fixed in the openstack/keystone 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.