[RFE] - Make clear differentiation between `ansible_user` and undercloud user that deploys the overcloud

[Harry Rybacki]

If we look way back to when OOOQ was initially developed by Trown up until rather recently, it was generally assumed that the 'stack' user would always be the user setup on the undercloud and used to deploy the overcloud. However, as we grown, refined, and expanded OOOQ and OOOQ-Extras this assumption is no longer valid. To make things slightly more complicated, we have decoupled hardcoded

In order for allow decouple the stack user we have opted to use 'ansible_user' e.g.[1] which is, by default, set to 'stack' in the common role[2].

To further help clear up cruft, we are also working towards a unified set of defaults such that roles within OOOQ-Extras depend on the extras-common role[3] and the extras-common role depends on the common role[4]. However, both [3] and [4] are bringing to light problems with using 'ansible_user' in such a broad manner[5]:

```
TASK [undercloud-deploy : Create undercloud install script] ********************
task path: /home/centos/workspace/tripleo-quickstart-extras-gate-mitaka-delorean-full-minimal@2/usr/local/share/ansible/roles/undercloud-deploy/tasks/create-scripts.yml:15
Thursday 05 January 2017 21:59:44 +0000 (0:00:04.648) 0:10:40.734 ******
fatal: [undercloud]: FAILED! => {"changed": true, "failed": true, "msg": "Destination directory /home/stack/.quickstart does not exist"}
```

Using 'ansible_user' rather than stack[1] has also created issues with the collect-logs role as upstream, ci.centos, and internal pipelines all have varying setup/environment requirements. Presently logging is broken in ci.centos as well as for internal (RH) jobs[6].

Let's start a discussion around creating a solution. Perhaps having a distinct 'undercloud_user' variable that would fall into where we have classically seen 'stack' would suffice.

[1] - https://review.openstack.org/#/c/404800/
[2] - https://github.com/openstack/tripleo-quickstart/blob/master/roles/common/defaults/main.yml#L7
[3] - https://review.openstack.org/#/c/413800/
[4] - https://review.openstack.org/#/c/417195/
[5] - https://ci.centos.org/artifacts/rdo/jenkins-tripleo-quickstart-extras-gate-mitaka-delorean-full-minimal-482/console.txt.gz
[6] - https://bugs.launchpad.net/tripleo-quickstart/+bug/1654003

[Attila Darazs (adarazs)]

+1 for using introducing the `undercloud_user` variable which should default to `stack` and used in the places where we hardcoded it previously. This would the issues we have while making the undercloud deployments more flexible.

[wes hayutin (weshayutin)]

+1 on undercloud_user

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/417502

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417502
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=6cd30f492c37099bfd1a53d7a2fda3a4e926cea7
Submitter: Jenkins
Branch: master

commit 6cd30f492c37099bfd1a53d7a2fda3a4e926cea7
Author: Harry Rybacki <email address hidden>
Date: Fri Jan 6 14:09:44 2017 -0500

    Integrate undercloud_user var int oooq

    We need to differentiate local_working_dir from working_dir
    as well as decouple the stack user from `ansible_user` var.
    Both of these are causing issues as we begin to automate
    deployments in more environments.

    - update common/defaults to use undercloud_user
    - make tripleo-inventory inherit from common role, pull
      duplicate vars out of its defaults
    - make convert-image inherit from common role, update
      template to use undercloud_user
    - update libvirt/setup/undercloud to use undercloud_user

    Related-bug: 1654574

    Change-Id: I45b0706df8351ff9ddc6c226989125dcb2f5b897

[Harry Rybacki (hrybacki-h)]

Fix has been reviewed and merged: https://review.openstack.org/#/c/419639

[Harry Rybacki (hrybacki-h)]

Disregard comment #5 -- wrong launchpad/browser tab.

[Attila Darazs (adarazs)]

This bug is in fact solved by the change in comment #4, so closing it.