Staff can get stuck in loop with Place Another Hold for this Title link

[Kathy Lussier]

Evergreen version: all supported versions

When I added the Place Another Hold link to the hold result page, I included a new hold_source_page parameter to track where the user should be returned to after hitting the 'Continue' button. However, I neglected to update the link for the 'Continue' button so that it would use this hold_source_page. Instead, it will redirect users to the previous page.

The result is that, once staff use the "Place Another Hold for this Title" link, they will be stuck in a loop where they return to the Place Hold page no matter which option they choose on the hold result page.

[Kathy Lussier (klussier)]

Looks like my diagnosis was incorrect. We inadvertently removed a hidden field in commit 01c32c5 that was necessary to track the hold_source_page.

While I was looking at the code, though, I noticed that the hold type labels included in the link were not translatable. Fixes to both issues are available in the branch at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1654534-stop-place-another-hold-loop

[Ben Shum (bshum)]

Tested the problem and was able to duplicate the issue. Tested the fix and the problem went away.

Pushing bug fix to master and backported to rel_2_11 and rel_2_10. Thanks Kathy!