ubuntu store snap click-review error

[Alvaro Luis Bustamante]

I cannot publish snap packages in the Ubuntu store as the server automatically rejects my snap. It does not provide too much information:

Automated review for version 1.1.4: failed
 1 Fail
Unexpected output from click-review. click-review

I have tried to run the click-review on my own, and this is the output (NOTICE the RUNTIME ERROR):

$ click-review -v thinger-maker-server_1.1.4_amd64.snap
Info
----
 - security-snap-v2:app_plug_safe:thingerd:network
        OK
 - security-snap-v2:app_plug_safe:thingerd:network-bind
        OK
 - security-snap-v2:policy-vendor
        OK
 - security-snap-v2:policy-version
        OK
 - security-snap-v2:profile_name_length:thingerd
        OK
 - security-snap-v2:squashfs_repack_checksum
        OK
thinger-maker-server_1.1.4_amd64.snap: RUNTIME ERROR

If I run the same click-review with --sdk argument, this is the output:

$ click-review --sdk thinger-maker-server_1.1.4_amd64.snap
= click,snap.v1_bin_path =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_content_hub =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_desktop =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_framework =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_functional =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_lint =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_online_accounts =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_push_helper =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_scope =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_security =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_systemd =
{
  "error": {},
  "info": {},
  "warn": {}
}
= click,snap.v1_url_dispatcher =
{
  "error": {},
  "info": {},
  "warn": {}
}
= snap.v2_security =
{
  "error": {},
  "info": {
    "security-snap-v2:app_plug_safe:thingerd:network": {
      "manual_review": false,
      "text": "OK"
    },
    "security-snap-v2:app_plug_safe:thingerd:network-bind": {
      "manual_review": false,
      "text": "OK"
    },
    "security-snap-v2:policy-vendor": {
      "manual_review": false,
      "text": "OK"
    },
    "security-snap-v2:policy-version": {
      "manual_review": false,
      "text": "OK"
    },
    "security-snap-v2:profile_name_length:thingerd": {
      "manual_review": false,
      "text": "OK"
    },
    "security-snap-v2:squashfs_repack_checksum": {
      "manual_review": false,
      "text": "OK"
    }
  },
  "warn": {}
}

Everything seems to be ok, so, what is the problem??

[Jamie Strandboge (jdstrand)]

Alvaro, the store 'click-review' and the click-review available in debs are at different versions. Running from a fresh checkout:

$ PYTHONPATH=./ ./bin/click-review ~/Desktop/thinger_1.snap
Caught exception (setting rc=1 and continuing):
Traceback (most recent call last):
  File "./bin/click-review", line 105, in _run_module_checks
    review.do_checks()
  File "/home/jamie/bzr-pulls/click-reviewers-tools.trunk/clickreviews/common.py", line 329, in do_checks
    func()
  File "/home/jamie/bzr-pulls/click-reviewers-tools.trunk/clickreviews/sr_lint.py", line 561, in check_apps_stop_timeout
    self.snap_yaml['apps'][app][key]
TypeError: %d format: a number is required, not str
/home/jamie/Desktop/thinger_1.snap: RUNTIME ERROR

Your snap.yaml has:

apps:
  thingerd:
    command: command-thingerd.wrapper
    daemon: forking
    plugs:
    - network
    - network-bind
    restart-condition: always
    stop-timeout: 120s

It looks like the snap format changed incompatibly with the review tools based on https://github.com/snapcore/snapd/wiki/Snap-format:

      # Optional time to wait for daemon to stop.
      stop-timeout: <n>ns | <n>us | <n>ms | <n>s | <n>m

These are now required to be strings with a suffix.

[Jamie Strandboge (jdstrand)]

Moving to the proper project. I'll get this fixed up in the review tools right away.

[Jamie Strandboge (jdstrand)]

This is fixed in trunk and I've requested the store to pull in the fixes.

[Alvaro Luis Bustamante (alvarolb)]

Nice! Thanks for the fix! :)

[Jamie Strandboge (jdstrand)]

The store has had this fix for some time.