Modal header should default to page_header

Bug #1653960 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Unassigned

Bug Description

Many modals have a modal_header value that is identical to page_header; we could just default to page_header and remove the duplication.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
importance: Undecided → Wishlist
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/416552

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/416552
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=83e3ff88ec2f3b776c282bdb73fdf23cb2ab3468
Submitter: Jenkins
Branch: master

commit 83e3ff88ec2f3b776c282bdb73fdf23cb2ab3468
Author: Rob Cresswell <email address hidden>
Date: Wed Jan 4 13:31:36 2017 +0000

    Remove duplicated modal_header statements

    Across the codebase we've been using modal_header values that are
    identical (or very close to) the page_title values. This patch sets the
    modal_header to default to the page_title value, and cleans up a few
    inconsistencies. Also deleted a couple of redundant submit_label values
    that were identical to the default ("Submit").

    Change-Id: I88815c3801c29b3fbc41e0cb426a50653255595f
    Closes-Bug: 1653960

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b3

This issue was fixed in the openstack/horizon 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.