OpenStack Dashboard (Horizon)

admin dashboard appearing when it shouldn't

Bug #1653792 reported by David Lyle on 2017-01-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	High	David Lyle	OpenStack Dashboard (Horizon) ocata-3 "o-3"

Bug Description

With commit https://github.com/openstack/horizon/commit/90f43f3356a889a54464a6ddad81a1ca2b9f6290 the handling of single rules was broken and was always returning True. This resulted in the admin dashboard showing up incorrectly as well as panels showing up inappropriately.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-03: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/416356

Changed in horizon:
status:	New → In Progress

Rob Cresswell (robcresswell-deactivatedaccount) on 2017-01-04

Changed in horizon:
milestone:	ocata-2 → ocata-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-04: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/416356
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5bce9a02509d123dcf1c96e43562dd7ed80a0f05
Submitter: Jenkins
Branch: master

commit 5bce9a02509d123dcf1c96e43562dd7ed80a0f05
Author: David Lyle <email address hidden>
Date: Tue Jan 3 14:30:43 2017 -0700

Fix single policy rule handling

    With commit 43e9df85ab286ddee96e9cff97f551781baf70d1 the handling
    of single policy rules was broken and always returned True for a
    single rule.

    One of the visible results is that the Admin Dashboard showed up
    incorrectly for users that lacked permission to see it. Additionally,
    panel in the Admin Dashboard were also visible.

This patch fixes single rule handling, and the visible effects.

Closes-Bug: #1653792
Change-Id: I0c8a0d7b230b6c6b7ee048af84646ca95daee340

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-26: Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/425874

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-26: Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/425874
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8d9665302ae1b2abd772843483ce14ade4659c6d
Submitter: Jenkins
Branch: stable/newton

commit 8d9665302ae1b2abd772843483ce14ade4659c6d
Author: David Lyle <email address hidden>
Date: Tue Jan 3 14:30:43 2017 -0700

Fix single policy rule handling

    With commit 43e9df85ab286ddee96e9cff97f551781baf70d1 the handling
    of single policy rules was broken and always returned True for a
    single rule.

    One of the visible results is that the Admin Dashboard showed up
    incorrectly for users that lacked permission to see it. Additionally,
    panel in the Admin Dashboard were also visible.

This patch fixes single rule handling, and the visible effects.

    Closes-Bug: #1653792
    Change-Id: I0c8a0d7b230b6c6b7ee048af84646ca95daee340
    (cherry picked from commit 5bce9a02509d123dcf1c96e43562dd7ed80a0f05)