budgie-desktop needs to display the nm-applet icon in the panel

Bug #1653739 reported by fossfreedom
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
budgie-desktop (Ubuntu)
Fix Released
Medium
fossfreedom

Bug Description

As the debian maintainer of budgie-desktop I have recently pushed v10.2.9-2 and this has been sync'd via Debian.

The nm-applet no longer displays in the panel. This is because Ubuntu has a specific patch to nm-applet that assumes app-indicators is the default display mechanism not the X11 tray icon.

Thus Ubuntu Budgie needs a specific ubuntu only patch to run nm-applet with the parameter --no-indicator

Note - whilst we do support appindicators - our appindicator deliberately hides nm-applet because we follow upstream plans which include a separate network-manager applet built specifically for budgie-desktop. Thus we don't want future complications of both the app-indicator and the separate applet both displaying the same info.

Additionally - those that install budgie-desktop without the appindicator package will also need to see and use the nm-applet functionality.

Tags: patch
Changed in budgie-desktop (Ubuntu):
status: New → In Progress
assignee: nobody → fossfreedom (fossfreedom)
Revision history for this message
fossfreedom (fossfreedom) wrote :

This patch adds the --no-indicator param to the /etc/xdg/autostart file that launches nm-applet.

description: updated
Revision history for this message
fossfreedom (fossfreedom) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "show_nm-applet_in_tray.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Robie Basak (racb) wrote :

12:40 <rbasak> fossfreedom_: that looks fine. I didn't think there was any such thing as an "X11 tray icon" though? I was under the impression that they were done via GNOME's stuff or something (as opposed to the indicator infrastructure).

12:41 <rbasak> fossfreedom_: a second thought: shouldn't this be fixed in our delta against nm-applet, rather than working around it in Budgie?

12:42 <rbasak> For example is it possible to detect at runtime whether indicators are in use?

12:48 <fossfreedom_> rbasak: I like the idea of rejigging nm-applet to detect. However I don't really have an idea how to do this :(

12:50 <fossfreedom_> I mentioned X11 in the description simply because that is how upstream refers to the tray applet in budgie-desktop.

12:55 <fossfreedom_> Probably overthinking ... may not be possible to say in nm-applet "is app indicators in use" - the indicator service can be running - but the user might have simply removed the appindicator applet from the desktop. Sounds to be a bit messy.

13:06 <rbasak> fossfreedom_: OK. Where do you want me to sponsor the patch from? The attachment is only the quilt patch, not a debdiff, and I want to make sure you get full credit to help for your future upload access :-)

Revision history for this message
fossfreedom (fossfreedom) wrote :

Also attached a debdiff of the changes made

Mathew Hodson (mhodson)
Changed in budgie-desktop (Ubuntu):
importance: Undecided → Medium
Revision history for this message
fossfreedom (fossfreedom) wrote :

attached another debdiff with a more accurate description for the changelog and the patch itself

Revision history for this message
Robie Basak (racb) wrote :

Uploaded. Thanks!

Changed in budgie-desktop (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package budgie-desktop - 10.2.9-2ubuntu1

---------------
budgie-desktop (10.2.9-2ubuntu1) zesty; urgency=medium

  * Bug-fix release (LP: #1653739)
    - Run nm-applet without indicators to ensure it works on
      budgie-desktop, flipping Ubuntu's default.

 -- David Mohammed <email address hidden> Tue, 03 Jan 2017 19:48:38 +0000

Changed in budgie-desktop (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.