Crash in DismantleSite::draw ...RenderTarget::blit

[Klaus Halfmann]

I was playing the economy tutorial on bzr8228[simplify_messagebox],
assuming that there are a lot of messageboxes there.
While dismanteling some barrack I got a crash.

0 widelands 0x000000010e17b593 (anonymous namespace)::RTImage::width() const + 35 (font_handler1.cc:76)
1 widelands 0x000000010e180bb4 RenderTarget::blit(Vector2<float> const&, Image const*, BlendMode, UI::Align) + 68 (rendertarget.cc:150)
2 widelands 0x000000010e32d4ea Widelands::MapObject::do_draw_info(TextToDraw const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Vector2<float> const&, float, RenderTarget*) const + 1242 (map_object.cc:484)
3 widelands 0x000000010e347763 Widelands::Building::draw_info(TextToDraw, Vector2<float> const&, float, RenderTarget*) + 323 (building.cc:624)
4 widelands 0x000000010e3570cf Widelands::DismantleSite::draw(unsigned int, TextToDraw, Vector2<float> const&, float, RenderTarget*) + 559 (dismantlesite.cc:239)
5 widelands 0x000000010ea743b8 (anonymous namespace)::draw_objects_for_visible_field(Widelands::EditorGameBase const&, FieldsToDraw::Field const&, float, TextToDraw, Widelands::Player const*, RenderTarget*) + 456 (game_renderer.cc:119)
6 widelands 0x000000010ea71e02 (anonymous namespace)::draw_objects(Widelands::EditorGameBase const&, float, FieldsToDraw const&, Widelands::Player const*, TextToDraw, RenderTarget*) + 1618 (game_renderer.cc:242)
7 widelands 0x000000010ea71355 GameRenderer::draw(Widelands::EditorGameBase const&, Vector2<float> const&, float, TextToDraw, Widelands::Player const*, RenderTarget*) + 2949 (game_renderer.cc:454)
8 widelands 0x000000010ea707c6 GameRenderer::rendermap(Widelands::EditorGameBase const&, Vector2<float> const&, float, Widelands::Player const&, TextToDraw, RenderTarget*) + 70 (game_renderer.cc:319)

(Complete Apple carsh report will be attached)

[Klaus Halfmann (klaus-halfmann)]

Here the autosave just before the crash,
just tear down ever barrack that is occupied while
building another one to gain more space

[Klaus Halfmann (klaus-halfmann)]

This is OSX, compiling with clang using libs from MacPorts mostly.
More details if needed ...

[Klaus Halfmann (klaus-halfmann)]

Here is another crash in the Tuorial, After some other (lua related) Error, the Tuorial
is not playable any longer and I will stop testing this now. But test some other Branch.

[SirVer (sirver)]

#4 seems different to the original crash. Some MapObject that is used after being freed.

[GunChleoc (gunchleoc)]

We fixed font handler crashes with ASan, so I'm assuming that this bug is fixed.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1