Cinder

Retype with migration does not move volumes

Bug #1652802 reported by Erlon R. Cruz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Erlon R. Cruz
Cinder ocata-3 "o3"

Bug Description

After the commit to support HA A/A on scheduler operations[1], retyping a volume triggering a migration always succeeds (but volume is not migrated) if the source backend have a 'retype' function implemented, even if the volumes are not in the same backend.

[1] https://review.openstack.org/#/c/344226/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/421353

Changed in cinder:
assignee: nobody → Erlon R. Cruz (sombrafam)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/421439

Changed in cinder:
assignee: Erlon R. Cruz (sombrafam) → Gorka Eguileor (gorka)
Ivan Kolodyazhny (e0ne)
Changed in cinder:
importance: Undecided → High
Michal Dulko (michal-dulko-f)
Changed in cinder:
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Erlon R. Cruz (<email address hidden>) on branch: master
Review: https://review.openstack.org/421353
Reason: Abandoning in favor of: https://review.openstack.org/#/c/421439

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Gorka Eguileor (gorka) → Erlon R. Cruz (sombrafam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/421439
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=dafd68eaddaef81ae48786448bc1e7c1dd4fd912
Submitter: Jenkins
Branch: master

commit dafd68eaddaef81ae48786448bc1e7c1dd4fd912
Author: Gorka Eguileor <email address hidden>
Date: Tue Jan 17 18:34:25 2017 +0100

    Fix retype with migrate

    When a retype requires migrating a volume the check on the volume
    manager will always consider that there's no need to migrate so it will
    not try to migrate the volume but retype it instead, so in drivers that
    implement `retype` (like LVM) it will falsely report success.

    This patch fixes the check to detect if the volume is in our own
    backend.

    Closes-bug: #1652802
    Change-Id: I5e977ed412cf4a1614d7728ffe7898435291fcc3

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0b3

This issue was fixed in the openstack/cinder 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.