failed to retrieve vnfd on tacker horizon

[futangw]

Hello,

After install the tacker-horizon-master (previously it's 0.5.0), the tacker horizon failed to retrieve VNF catalog with 'Error: Unable to get instances'. it's failed in function get_vnfcatalog_data() with an except.

the root cause is clear now that it was caused by code change in tacker _make_service_types_list().

on tacker 0.5.0, the code:
 178 def _make_service_types_list(self, service_types):
 179 return [{'id': service_type.id,
 180 'service_type': service_type.service_type}
 181 for service_type in service_types]

on tacker master, the code:
 176 def _make_service_types_list(self, service_types):
 177 return [service_type.service_type
 178 for service_type in service_types]

So the new code will return a list with string element inside. This will caused an except in line 56 below of the function get_vnfcatalog_data():
 |- 53 services = vnfd['service_types']
|| 54 vnfd_services = []
|| 55 for s in services: ## services now is, e.g. [u'vnfd']
|| 56 if s['service_type'] != 'vnfd':
||- 57 vnfd_services.append(s['service_type'])

the code may be udpated to:
                            services = vnfd['service_types']
                            vnfd_services = []
                           for s in services: ## services now is, e.g. [u'vnfd']
                                  vnfd_services.append(s)

Merry Christmas and Happy New Year.

futangw

[Sridhar Ramaswamy (srics-r)]

Thanks for reporting the problem *and* providing a possible fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/416418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/416418
Committed: https://git.openstack.org/cgit/openstack/tacker-horizon/commit/?id=04a26f375f47813c83dead3c2312c05fa2b1394f
Submitter: Jenkins
Branch: master

commit 04a26f375f47813c83dead3c2312c05fa2b1394f
Author: gong yong sheng <[e-mail]>
Date: Wed Jan 4 03:16:41 2017 +0000

    Get service type according to tacker server change

    https://review.openstack.org/#/c/390787/ changed the service
    type in vnfd dict, the horizon should change accordingly.

    This patch also change the column name of service type.

    Change-Id: I95a11027dd3c658a2689257b0bbd717c05ae10a1
    Closes-bug: #1652751

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tacker-horizon 0.6.0 release.