stack stuck in IN_PROGRESS with invalid external_id

[Rabi Mishra]

1. Creating stack with a wrong external_id, results in the stack stuck in IN_PROGRESS and the resource stuck in INIT_COMPLETE.

[stack@f24-devstack ~]$ cat server.yaml
heat_template_version: newton
resources:
  server:
    type: OS::Nova::Server
    external_id: 774a9a4a-ddbf-4037-8d11-356d5438c972
    properties:
      flavor: m1.nano
      image: cirros-0.3.4-x86_64-uec
[stack@f24-devstack ~]$ heat stack-create test_stack -f server.yaml
WARNING (shell) "heat stack-create" is deprecated, please use "openstack stack create" instead
WARNING (shell) "heat stack-list" is deprecated, please use "openstack stack list" instead
+--------------------------------------+------------+--------------------+----------------------+--------------+
| id | stack_name | stack_status | creation_time | updated_time |
+--------------------------------------+------------+--------------------+----------------------+--------------+
| 3a5ec529-2129-4657-8113-bd5087efc273 | test_stack | CREATE_IN_PROGRESS | 2016-12-21T08:29:08Z | None |
+--------------------------------------+------------+--------------------+----------------------+--------------+
[stack@f24-devstack ~]$ heat resource-list test_stack
WARNING (shell) "heat resource-list" is deprecated, please use "openstack stack resource list" instead
+---------------+----------------------+------------------+-----------------+----------------------+
| resource_name | physical_resource_id | resource_type | resource_status | updated_time |
+---------------+----------------------+------------------+-----------------+----------------------+
| server | | OS::Nova::Server | INIT_COMPLETE | 2016-12-21T08:29:09Z |
+---------------+----------------------+------------------+-----------------+----------------------+

2. Also creating stack with external_id and an invalid property results in validation failure.

change a property flavor to 'm1.xxx'

[stack@f24-devstack ~]$ heat stack-create test_stack -f server.yaml
WARNING (shell) "heat stack-create" is deprecated, please use "openstack stack create" instead
ERROR: Property error: : resources.server.properties.flavor: : Error validating value 'm1.xxx': No Flavor matching {'name': u'm1.xxx'}. (HTTP 404)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413507

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413507
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=eb7b5a3d49aa89651432288025e60bc47f466dab
Submitter: Jenkins
Branch: master

commit eb7b5a3d49aa89651432288025e60bc47f466dab
Author: rabi <email address hidden>
Date: Wed Dec 21 10:30:54 2016 +0530

    Don't validate rsrc properties with external_id

    This also moves the external_id validation
    from resource create to stack validate.

    Change-Id: I815599ea3eb8d62a81a78f5e2e2dfc8c9f6dec05
    Closes-Bug: #1651681

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 8.0.0.0b3 development milestone.