Custom network names prevent deployment

[Christopher Brown]

We have a requirement to use custom network names, for example:

  StorageMgmtNetCidr: 10.0.10.0/24
  StorageMgmtAllocationPools: [{'start': '10.0.10.50', 'end': '10.0.10.110'}]
  StorageMgmtNetworkVlanID: 109
  StorageMgmtNetName: customstgmgmtname

  InternalApiNetCidr: 10.0.11.0/24
  InternalApiAllocationPools: [{'start': '10.0.11.50', 'end': '10.0.11.110'}]
  InternalApiNetworkVlanID: 107
  InternalApiNetName: custominternalapiname

However when we try to deploy with these, we get:

{u'deploy_stdout': u"Matching apachectl 'Server version: Apache/2.4.6 (Red Hat Enterprise Linux)\nServer built: Aug 3 2016 08:33:27'\n", u'deploy_stderr': u'exception: connect |
| | failed\n\x1b[1;31mError: Could not find data item memcached_node_ips in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp:67

We are using predictable IP addresses and custom hostname also.

For Red Hat folks please see case number: 01760629

to which I have attached sos reports, templates etc.

[Steven Hardy (shardy)]

I think this is because we've mistakenly got some hard-coded references to the default names which crept in via the custom roles rework we (I) did in Newton, in particular I think this is problematic:

https://github.com/openstack/tripleo-heat-templates/blob/master/network/ports/net_ip_list_map.yaml#L69

there may be some others, will try to reproduce and report back.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413625

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413626

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413625
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=24952e016fc0abd5023cefad8c2d057890fe7a16
Submitter: Jenkins
Branch: master

commit 24952e016fc0abd5023cefad8c2d057890fe7a16
Author: Steven Hardy <email address hidden>
Date: Wed Dec 21 11:54:46 2016 +0000

    Make ServiceNetMap support custom network names

    The rework to support custom roles moved the service net map
    into a nested stack, but the logic it contains fails to consider
    operators may override the network names via *NetName parameters.

    So add a map_replace of the ServiceNetMapDefaults so we maintain
    the existing default service->network assignments, even when the
    network name is changed.

    Note that operators will still be expected to pass any ServiceNetMap
    overrides with the "new" network name, e.g whatever *NetName specifies,
    otherwise I think environment files could get very confusing.

    Change-Id: I52018e19428e11d26650f0ea6ccee3ae02494ff8
    Partial-Bug: #1651541

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413626
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=47f2579fa24e722b451c29b5f6435c5b5fe65429
Submitter: Jenkins
Branch: master

commit 47f2579fa24e722b451c29b5f6435c5b5fe65429
Author: Steven Hardy <email address hidden>
Date: Wed Dec 21 13:19:20 2016 +0000

    Don't assume default network names in net_ip*map

    This needs to handle a ServiceNetMap containing non-default
    network names when they are overridden via the *NetName parameters.

    Closes-Bug: #1651541
    Change-Id: I95d808444642a37612a495e822e50449a7e7da63

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/438297

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438297
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=daac054979f112d612aad89f9655f613b3c7a57f
Submitter: Jenkins
Branch: stable/ocata

commit daac054979f112d612aad89f9655f613b3c7a57f
Author: Steven Hardy <email address hidden>
Date: Wed Dec 21 13:19:20 2016 +0000

    Don't assume default network names in net_ip*map

    This needs to handle a ServiceNetMap containing non-default
    network names when they are overridden via the *NetName parameters.

    Closes-Bug: #1651541
    Change-Id: I95d808444642a37612a495e822e50449a7e7da63
    (cherry picked from commit 47f2579fa24e722b451c29b5f6435c5b5fe65429)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/446112

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/446112
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0d0e5c8f63b5300a7907881bfa55c621c2b89799
Submitter: Jenkins
Branch: stable/newton

commit 0d0e5c8f63b5300a7907881bfa55c621c2b89799
Author: Steven Hardy <email address hidden>
Date: Wed Dec 21 11:54:46 2016 +0000

    Make ServiceNetMap support custom network names

    The rework to support custom roles moved the service net map
    into a nested stack, but the logic it contains fails to consider
    operators may override the network names via *NetName parameters.

    So add a map_replace of the ServiceNetMapDefaults so we maintain
    the existing default service->network assignments, even when the
    network name is changed.

    Note that operators will still be expected to pass any ServiceNetMap
    overrides with the "new" network name, e.g whatever *NetName specifies,
    otherwise I think environment files could get very confusing.

    Change-Id: I52018e19428e11d26650f0ea6ccee3ae02494ff8
    Partial-Bug: #1651541
    (cherry picked from commit 24952e016fc0abd5023cefad8c2d057890fe7a16)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.