SRUs must enforce Launchpad-Bugs-Fixed: field

[Dimitri John Ledkov]

There is currently a pending sru for webbrowser app, which has following .changes file:

Format: 1.8
Date: Fri, 28 Oct 2016 09:17:33 +0000
Source: webbrowser-app
Binary: webbrowser-app webapp-container qml-module-ubuntu-ui-extras-browser qtdeclarative5-ubuntu-ui-extras-browser-plugin qml-module-ubuntu-web qtdeclarative5-ubuntu-web-plugin qml-module-ubuntu-web-doc qtdeclarative5-ubuntu-web-plugin-doc webbrowser-app-autopilot webapp-container-autopilot
Architecture: source
Version: 0.23+16.04.20161028-0ubuntu1
Distribution: xenial
Urgency: medium
Maintainer: Ubuntu Developers <email address hidden>
Changed-By: Olivier Tilloy <email address hidden>
Description:
 qml-module-ubuntu-ui-extras-browser - Ubuntu web QML module
 qml-module-ubuntu-web - Ubuntu web QML module
 qml-module-ubuntu-web-doc - Ubuntu web QML module HTML documentation
 qtdeclarative5-ubuntu-ui-extras-browser-plugin - transitional dummy package for the Ubuntu web QML module
 qtdeclarative5-ubuntu-web-plugin - transitional dummy package for the Ubuntu web QML module
 qtdeclarative5-ubuntu-web-plugin-doc - transitional dummy package for the Ubuntu web QML module HTML doc
 webapp-container - Ubuntu web applications container
 webapp-container-autopilot - Ubuntu web applications container autopilot tests
 webbrowser-app - Ubuntu web browser
 webbrowser-app-autopilot - Ubuntu web browser autopilot tests
Changes:
 webbrowser-app (0.23+16.04.20161028-0ubuntu1) xenial; urgency=medium
 .
   * SRU for selected bug fixes:
     - LP #1565055: support for google hangouts
     - LP #1573017: SAML detection logic broken in webapp container
     - LP #1572673: invalid variable access error in webapp container
     - LP #1466427: dynamic Ubuntu version in default UA string
     - LP #1576639: fine-tune the custom memory-pressure handler
     - LP #1581025: secure connection icon not showing
     - LP #1580290: only load the current tab when the session is restored
     - LP #1577806: browser and container open under the same instance
     - LP #1565063: dynamic Chromium version in default UA string
Checksums-Sha1:
 9c13d9635a3136cc19ad466e856179ae4a676002 3450 webbrowser-app_0.23+16.04.20161028-0ubuntu1.dsc
 79946ba56a0ab0373ce786bc2ced510039afd112 1145445 webbrowser-app_0.23+16.04.20161028.orig.tar.gz
 5c2a0e82ee751504877df3ab8a10a72e7d27c029 41104 webbrowser-app_0.23+16.04.20161028-0ubuntu1.diff.gz
Checksums-Sha256:
 50d8c23ab6dcddef69f27e637beb64b02323e1b5b19a792467292db9a4d70a2e 3450 webbrowser-app_0.23+16.04.20161028-0ubuntu1.dsc
 4002db92db166d2b866d6cd8d1b10478f4f495f9dabf42b7f64357db38c6b522 1145445 webbrowser-app_0.23+16.04.20161028.orig.tar.gz
 0f1aa3acdc3e13b8e118be08c886f757b2772bba424373fa840d44dd2e10182a 41104 webbrowser-app_0.23+16.04.20161028-0ubuntu1.diff.gz
Files:
 3f28fd2cf54ab18f3ac5c73c8e2ba318 3450 x11 optional webbrowser-app_0.23+16.04.20161028-0ubuntu1.dsc
 0c583faf1b3c1d65427b20c568b39811 1145445 x11 optional webbrowser-app_0.23+16.04.20161028.orig.tar.gz
 1c83dbc45921ef1063df56e57ac1386e 41104 x11 optional webbrowser-app_0.23+16.04.20161028-0ubuntu1.diff.gz

Note that the bug references are incorrect, as they are missing ":" after LP, and therefore were not processed into "Launchpad-Bugs-Fixed: " field in the changes file which is used by launchpad janitor to close bugs; pending-sru report to track bugs; etc.

I believe this upload was done via bileto, and it should enforce that "Launchpad-Bugs-Fixed: " ends up in present in the .changes file.

https://launchpad.net/ubuntu/+source/webbrowser-app/0.23+16.04.20161028-0ubuntu1

[Olivier Tilloy (osomon)]

The upload was done by bileto but the wrong formatting is my doing, as I added a custom changelog entry to override the one that would have been generated by bileto. Still it would be useful if bileto complained/warned about this sort of situation.

[Robert Bruce Park (robru)]

Yes bileto doesn't make changes files so this is indeed user error with changelog formatting. I'll consider adding a check for this if I get some time but really whatever part of dpkg-buildpackage normally adds those bug references is not a feature of bileto.

[Dimitri John Ledkov (xnox)]

Yeap, this is just the request for safety check / warning message on package built.