Metadata 'scaling_in_progress' is always true

Bug #1651084 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
huangtianhua

Bug Description

We set metadata 'scaling_in_progress=True' of scaling_policy and autocaling_group when scaling, if engine service down during scaling, then the metadata 'scaling_in_progress' is always True after the engine service back. Then we can't scaling anymore.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413060

Changed in heat:
status: New → In Progress
Revision history for this message
Rabi Mishra (rabi) wrote :

How would the someone know about it? This message[1] is what the operator would see in the logs, which does not convey much. It would be good if we can atleast make the message meaningful.

[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/scaling_policy.py#L177-L182

Changed in heat:
milestone: none → ocata-3
Revision history for this message
huangtianhua (huangtianhua) wrote :

@Rabi:
Thank you!
I agree with you, the message is not good enough, will propose a patch for that:)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/413060
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5b04acb4e25efbea58de998278e390fb64d7c575
Submitter: Jenkins
Branch: master

commit 5b04acb4e25efbea58de998278e390fb64d7c575
Author: huangtianhua <email address hidden>
Date: Tue Dec 20 20:29:59 2016 +0800

    To reset metadata for resources when mark unhealthy

    Some resources do not work if their metadata is in
    a wrong state, .e.g the metadata 'scaling_in_progress'
    of scaling group/policy might be always True if engine
    restarts while scaling.
    This patch adds an interface 'handle_metadata_reset' for
    resource, then the plugins can override it if needed.
    We reset the metadata while marking resource healthy.

    Change-Id: Ibd6c18acf6f3f24cf9bf16a524127850968062bc
    Closes-Bug: #1651084

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/417794

tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/420271

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/mitaka)

Reviewed: https://review.openstack.org/420271
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=70136e8b812749b227372740926e17d893e23b7d
Submitter: Jenkins
Branch: stable/mitaka

commit 70136e8b812749b227372740926e17d893e23b7d
Author: huangtianhua <email address hidden>
Date: Tue Dec 20 20:29:59 2016 +0800

    To reset metadata for resources when mark unhealthy

    Some resources do not work if their metadata is in
    a wrong state, .e.g the metadata 'scaling_in_progress'
    of scaling group/policy might be always True if engine
    restarts while scaling.
    This patch adds an interface 'handle_metadata_reset' for
    resource, then the plugins can override it if needed.
    We reset the metadata while marking resource healthy.

    Closes-Bug: #1651084
    (cherry picked from commit 5b04acb4e25efbea58de998278e390fb64d7c575)

    Conflicts:
     heat/scaling/cooldown.py
     heat/tests/engine/service/test_stack_resources.py
    Change-Id: Ibd6c18acf6f3f24cf9bf16a524127850968062bc

tags: added: in-stable-mitaka
tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/newton)

Reviewed: https://review.openstack.org/417794
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4db4f1e904fe12d794df0e3542ba4ba3a39e9f41
Submitter: Jenkins
Branch: stable/newton

commit 4db4f1e904fe12d794df0e3542ba4ba3a39e9f41
Author: huangtianhua <email address hidden>
Date: Tue Dec 20 20:29:59 2016 +0800

    To reset metadata for resources when mark unhealthy

    Some resources do not work if their metadata is in
    a wrong state, .e.g the metadata 'scaling_in_progress'
    of scaling group/policy might be always True if engine
    restarts while scaling.
    This patch adds an interface 'handle_metadata_reset' for
    resource, then the plugins can override it if needed.
    We reset the metadata while marking resource healthy.

    Closes-Bug: #1651084
    (cherry picked from commit 5b04acb4e25efbea58de998278e390fb64d7c575)

    Conflicts:
     heat/tests/engine/service/test_stack_resources.py
    Change-Id: Ibd6c18acf6f3f24cf9bf16a524127850968062bc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.0.0b3

This issue was fixed in the openstack/heat 8.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.2

This issue was fixed in the openstack/heat 7.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 6.1.1

This issue was fixed in the openstack/heat 6.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.