[fuel-library] CentOS 7.3 version misinterpreted as 6.x

[Alexandru Avadanii]

Recently, CentOS released version 7.3.1611, which triggered a latent bug in fuel-library puppet scripts at [1].

Since the match is not forced at the beggining of the version string (e.g. "/^6.+/: {" instead of "/6.+/: {"), the new CentOS 7.3.1611 matches the condition for 6.x.

stable/newton and master branches are not affected by this, since the switch-case in question was refactored to only support CentOS 7.x. Older branches, however, need to be patched.

Steps to reproduce:
1. Build ISO (from stable/mitaka branches)
2. Deploy ISO

Expected results:
Fuel master node is deployed fine, plugin installation works, all services are up.

Actual results:
Fuel plugins can't be installed since nailgun service is not up, due to failed missing dependencies (fence-agents, specific to CentOS 6.5, called fence-agents-all on CentOS 7.x, cannot be installed by puppet).

Description of the environment:
 Operation system: CentOS7.3.1611
 Versions of components: stable/mitaka
 Related projects installed: Armband Fuel@OPNFV
Additional information:
 While building Armband Fuel@OPNFV ISO from stable/mitaka branches of Fuel components, we stubled upon the above.

I will submit a patch shortly.

[1] https://github.com/openstack/fuel-library/blob/stable/mitaka/deployment/puppet/cobbler/manifests/packages.pp#L27

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410791
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9d3f3f1fd08e7179f543612ff8fb4f64ebd5077d
Submitter: Jenkins
Branch: stable/mitaka

commit 9d3f3f1fd08e7179f543612ff8fb4f64ebd5077d
Author: Alexandru Avadanii <email address hidden>
Date: Wed Dec 14 15:40:41 2016 +0100

    puppet: cobbler: Fix CentOS version detection

    Recently, CentOS released version 7.3.1611, which triggered a latent
    bug in fuel-library puppet scripts related to differentiating between
    6.x and 7.x major versions: 7.3.1611 is wrongly detected as 6.x,
    leading to the wrong packages being attempted to be installed,
    leaving nailgun server service broken on the Fuel Master node.

    This change forces the match at the beggining of the version string
    (e.g. "/^6.+/: {" instead of "/6.+/: {"), so the new CentOS 7.3.1611
    no longer matches the condition for 6.x).

    Closes-bug: 1649895

    Change-Id: I8873701d24e406e2804b9e654decb776ec3bf61c
    Signed-off-by: Alexandru Avadanii <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/410858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410858
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a3a1c4e96f6dc310b13e66fc5a90a5ea690b8218
Submitter: Jenkins
Branch: stable/8.0

commit a3a1c4e96f6dc310b13e66fc5a90a5ea690b8218
Author: Alexandru Avadanii <email address hidden>
Date: Wed Dec 14 15:40:41 2016 +0100

    puppet: cobbler: Fix CentOS version detection

    Recently, CentOS released version 7.3.1611, which triggered a latent
    bug in fuel-library puppet scripts related to differentiating between
    6.x and 7.x major versions: 7.3.1611 is wrongly detected as 6.x,
    leading to the wrong packages being attempted to be installed,
    leaving nailgun server service broken on the Fuel Master node.

    This change forces the match at the beggining of the version string
    (e.g. "/^6.+/: {" instead of "/6.+/: {"), so the new CentOS 7.3.1611
    no longer matches the condition for 6.x).

    Closes-bug: 1649895

    Change-Id: I8873701d24e406e2804b9e654decb776ec3bf61c
    Signed-off-by: Alexandru Avadanii <email address hidden>
    (cherry picked from commit 9d3f3f1fd08e7179f543612ff8fb4f64ebd5077d)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/454720

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/454720
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7c0fb226ea48f9c7c9fd493731dd02c03e687efc
Submitter: Jenkins
Branch: stable/8.0

commit 7c0fb226ea48f9c7c9fd493731dd02c03e687efc
Author: Anton Chevychalov <email address hidden>
Date: Fri Apr 7 16:25:16 2017 +0300

    Fix CentOS version detection

    Since the match is not forced at the beggining of the version string
    (e.g. "/^6.+/: {" instead of "/6.+/: {"), the new CentOS 7.3.1611
    matches the condition for 6.x.

    Change-Id: I5d7b04d95666e367b3e0b807580c4abdc345ab87
    Closes-bug: #1649895

[TatyanaGladysheva (tgladysheva)]

Verified on 8.0 + MU4 updates.

Latest runs with fix are passed:
https://packaging-ci.infra.mirantis.net/job/8.0-build.late.artifacts/